Differential D27066

remove pointless ifdef
AbandonedPublic
Actions

Authored by sitter on Jan 31 2020, 1:36 PM.

Details

Reviewers
mlaurent
Commits
R871:596c1b4f9d3d: remove pointless ifdef
Summary

the cast may not be necessary with <5.15 it will build all the same
since we are using legacy API here

Test Plan

build

Diff Detail

Repository
R871 DrKonqi
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21913
Build 21931: arc lint + arc unit
sitter created this revision.Jan 31 2020, 1:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 31 2020, 1:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jan 31 2020, 1:36 PM
mlaurent requested changes to this revision.Jan 31 2020, 1:47 PM

wrong as static_cast<void (QButtonGroup::*)(int)> is deprecated and it will not work without deprecated method.
Or you can convert it to static_cast<void (QButtonGroup::*)(QAbstractButton*)>
but "int" signal doesn't exist when we build without deprecarted method

This revision now requires changes to proceed.Jan 31 2020, 1:47 PM
sitter abandoned this revision.Jan 31 2020, 1:54 PM

Revision Contents
Changeset List

Diff 74777

View Options

src/bugzillaintegration/reportassistantpages_base.cpp

Loading...
View Options

src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp

Loading...