Differential D27012

Replace AboutDialog with Kirigami.AboutPage
ClosedPublic
Actions

Authored by nicolasfella on Jan 29 2020, 11:13 PM.

Details

Reviewers
mlaurent
Group Reviewers
Ruqola
Commits
R865:5c3df868e191: Replace AboutDialog with Kirigami.AboutPage
Summary

Kirgigami offers a standard component for this that looks nicer and allows us to drop quite some code

Diff Detail

Repository
R865 Ruqola
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Jan 29 2020, 11:13 PM
nicolasfella created this revision.
mlaurent accepted this revision.Jan 30 2020, 5:49 AM
This revision is now accepted and ready to land.Jan 30 2020, 5:49 AM
Closed by commit R865:5c3df868e191: Replace AboutDialog with Kirigami.AboutPage (authored by nicolasfella). · Explain WhyJan 30 2020, 10:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74663

View Options

src/apps/qml/qml/AboutDialog.qml

Loading...
View Options

src/apps/qml/qml/Desktop.qml

Loading...
View Options

src/apps/qml/qml/LicenseDialog.qml

Loading...
View Options

src/apps/qml/qml/qml.qrc

Loading...
View Options

src/core/CMakeLists.txt

Loading...
View Options

src/core/aboutdata/qmlaboutdata.h

Loading...
View Options

src/core/aboutdata/qmlaboutdata.cpp

Loading...
View Options

src/core/aboutdata/qmlaboutdataauthormodel.h

Loading...
View Options

src/core/aboutdata/qmlaboutdataauthormodel.cpp

Loading...
View Options

src/core/autotests/ruqolatest.cpp

Loading...
View Options

src/core/ruqola.h

Loading...
View Options

src/core/ruqola.cpp

Loading...
View Options

src/core/ruqolaregisterengine.cpp

Loading...