Turn AbstractClient::move() into a convenience method
Needs ReviewPublic

Authored by zzag on Jan 23 2020, 8:17 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

Maintaining two different ways of updating geometry can be challenging.
For what it's worth, prior to 5.18, move() didn't move the decoration
input window because someone forgot to update X11Client::doMove().

This change turns move() into a convenience method to simplify geometry
handling. It adds a little overhead, but on the other hand move() is
not used frequently.

Diff Detail

Repository
R108 KWin
Branch
move-wrap-set-frame-geometry
Lint
Lint ErrorsExcuse: fdfsafa
SeverityLocationCodeMessage
Errorinput.h:310CppcheckunknownMacro
Errorinput.h:310CppcheckunknownMacro
Errorinput.h:310CppcheckunknownMacro
Errorinput.h:310CppcheckunknownMacro
Errorinput.h:310CppcheckunknownMacro
Errorinput.h:310CppcheckunknownMacro
Errorutils.h:123CppcheckunknownMacro
Errorutils.h:123CppcheckunknownMacro
Unit
No Unit Test Coverage
Build Status
Buildable 21602
Build 21620: arc lint + arc unit
zzag created this revision.Jan 23 2020, 8:17 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 23 2020, 8:17 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jan 23 2020, 8:17 PM