Differential D26419

Typo fixes for umbrello
ClosedPublic
Actions

Authored by okellogg on Jan 4 2020, 1:28 PM.

Details

Reviewers

habacker

Summary

Diff was created against umbrello/master @ 51ed1e9.

Test Plan

Complete rebuild was done.

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

okellogg created this revision.Jan 4 2020, 1:28 PM

Restricted Application added a subscriber: umbrello-devel. · View Herald TranscriptJan 4 2020, 1:28 PM

okellogg requested review of this revision.Jan 4 2020, 1:28 PM

habacker accepted this revision.Jan 5 2020, 11:23 AM

This revision is now accepted and ready to land.Jan 5 2020, 11:23 AM

BTW: there is a new way to submit code changes to umbrello by creating gitlab merge requests at https://invent.kde.org/kde/umbrello/merge_requests

Please commit this patch yourself, otherwise I will be listed as author, as the unpatched arc does not use the original author or create a merge request.

If you do not know how to create a merge request, you must do so:

register at https://invent.kde.org.
fork https://invent.kde.org/kde/umbrello into your home project (click on button 'fork')
git clone your forked umbrello project
apply changes to the desired branch of the checked-out git repository
push the current branch into your forked umbrello project

this will display a link to open a corresponding merge request.

I followed the steps you described and created a merge request:
https://invent.kde.org/kde/umbrello/merge_requests/1

The Merge button appears greyed out for me saying

Ready to be merged automatically. Ask someone with write access to this repository to merge this request

Thanks,

Oliver

In D26419#588155, @okellogg wrote:

I followed the steps you described and created a merge request:
https://invent.kde.org/kde/umbrello/merge_requests/1

I merged this request into git master branch of kde/umbrello, thank you for your contribution.

The Merge button appears greyed out for me saying

Ready to be merged automatically. Ask someone with write access to this repository to merge this request

This is because you are not a member of the kde/umbrello project on invent.kde.org. File a member adding request at https://community.kde.org/Sysadmin for getting write access.

Revision Contents
Changeset List

			Path	Packages
M			lib/cppparser/lexercache.h (2 lines)
M			lib/interfaces/codemodel.h (4 lines)
M			lib/kdev4-php/completion/context.h (2 lines)
M			lib/kdev4-php/completion/keyworditem.h (2 lines)
M			lib/kdev4-php/completion/tests/bench_completion.cpp (2 lines)
M			lib/kdev4-php/completion/tests/test_completion.cpp (4 lines)
M			lib/kdev4-php/duchain/builders/declarationbuilder.h (4 lines)
M			lib/kdev4-php/duchain/tests/benchmarks.cpp (2 lines)
M			lib/kdev4-php/duchain/tests/expressionparser.cpp (4 lines)
M			lib/kdev5-php/completion/context.h (2 lines)
M			lib/kdev5-php/completion/tests/test_completion.cpp (4 lines)
M			lib/kdev5-php/duchain/builders/declarationbuilder.h (4 lines)
M			lib/kdev5-php/duchain/tests/expressionparser.cpp (4 lines)
M			umbrello/_unused/pluginloader.h (2 lines)
M			umbrello/assocrules.cpp (2 lines)
M			umbrello/basictypes.cpp (28 lines)
M			umbrello/clipboard/umlclipboard.cpp (2 lines)
M			umbrello/codegenerators/as/aswriter.cpp (2 lines)
M			umbrello/codegenerators/codeaccessormethod.h (10 lines)
M			umbrello/codegenerators/cpp/cppheadercodedocument.cpp (4 lines)
M			umbrello/codegenerators/cpp/cppsourcecodedocument.h (2 lines)
M			umbrello/codegenerators/cpp/cppwriter.cpp (6 lines)
M			umbrello/codegenerators/csharp/csharpwriter.cpp (2 lines)
M			umbrello/codegenerators/d/dclassifiercodedocument.cpp (4 lines)
M			umbrello/codegenerators/d/dcodegenerator.cpp (2 lines)
M			umbrello/codegenerators/d/dwriter.cpp (4 lines)
M			umbrello/codegenerators/java/javaclassifiercodedocument.cpp (4 lines)
M			umbrello/codegenerators/java/javacodegenerator.cpp (2 lines)
M			umbrello/codegenerators/java/javawriter.cpp (6 lines)
M			umbrello/codegenerators/js/jswriter.cpp (2 lines)
M			umbrello/codegenerators/php/php5writer.cpp (2 lines)
M			umbrello/codegenerators/php/phpwriter.cpp (2 lines)
M			umbrello/codegenerators/ruby/rubyclassifiercodedocument.cpp (2 lines)
M			umbrello/codegenerators/sql/sqlwriter.cpp (2 lines)
M			umbrello/codegenerators/textblock.h (2 lines)
M			umbrello/codegenerators/vala/valawriter.cpp (2 lines)
M			umbrello/codegenerators/xml/xmlschemawriter.h (2 lines)
M			umbrello/codegenerators/xml/xmlschemawriter.cpp (10 lines)
M			umbrello/codeimport/csharp/csharpimport.cpp (2 lines)
M			umbrello/codeimport/import_utils.h (2 lines)
M			umbrello/codeimport/import_utils.cpp (6 lines)
M			umbrello/codeimport/javaimport.cpp (2 lines)
M			umbrello/diagram_utils.cpp (2 lines)
M			umbrello/dialogs/codeeditor.cpp (2 lines)
M			umbrello/docgenerators/xhtmlgenerator.cpp (2 lines)
M			umbrello/toolbarstatemessages.h (2 lines)
M			umbrello/uml.cpp (4 lines)
M			umbrello/uml1model/association.cpp (2 lines)
M			umbrello/uml1model/foreignkeyconstraint.cpp (4 lines)
M			umbrello/umldoc.cpp (2 lines)
M			umbrello/umllistview.cpp (4 lines)
M			umbrello/umlscene.cpp (4 lines)
M			umbrello/umlwidgets/activitywidget.cpp (2 lines)
M			umbrello/umlwidgets/artifactwidget.h (2 lines)
M			umbrello/umlwidgets/artifactwidget.cpp (2 lines)
M			umbrello/umlwidgets/associationwidget.cpp (2 lines)
M			umbrello/umlwidgets/diagramproxywidget.cpp (4 lines)
M			umbrello/umlwidgets/objectnodewidget.cpp (2 lines)
M			umbrello/umlwidgets/objectwidget.h (2 lines)
M			umbrello/umlwidgets/widget_utils.cpp (2 lines)
M			umbrello/umlwidgets/widgetbase.cpp (2 lines)
M			unittests/testbase.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	72745			Jan 4 2020, 1:20 PM	★	★

Typo fixes for umbrelloClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 72745

lib/cppparser/lexercache.h

lib/interfaces/codemodel.h

lib/kdev4-php/completion/context.h

lib/kdev4-php/completion/keyworditem.h

lib/kdev4-php/completion/tests/bench_completion.cpp

lib/kdev4-php/completion/tests/test_completion.cpp

lib/kdev4-php/duchain/builders/declarationbuilder.h

lib/kdev4-php/duchain/tests/benchmarks.cpp

lib/kdev4-php/duchain/tests/expressionparser.cpp

lib/kdev5-php/completion/context.h

lib/kdev5-php/completion/tests/test_completion.cpp

lib/kdev5-php/duchain/builders/declarationbuilder.h

lib/kdev5-php/duchain/tests/expressionparser.cpp

umbrello/_unused/pluginloader.h

umbrello/assocrules.cpp

umbrello/basictypes.cpp

umbrello/clipboard/umlclipboard.cpp

umbrello/codegenerators/as/aswriter.cpp

umbrello/codegenerators/codeaccessormethod.h

umbrello/codegenerators/cpp/cppheadercodedocument.cpp

umbrello/codegenerators/cpp/cppsourcecodedocument.h

umbrello/codegenerators/cpp/cppwriter.cpp

umbrello/codegenerators/csharp/csharpwriter.cpp

umbrello/codegenerators/d/dclassifiercodedocument.cpp

umbrello/codegenerators/d/dcodegenerator.cpp

umbrello/codegenerators/d/dwriter.cpp

umbrello/codegenerators/java/javaclassifiercodedocument.cpp

umbrello/codegenerators/java/javacodegenerator.cpp

umbrello/codegenerators/java/javawriter.cpp

umbrello/codegenerators/js/jswriter.cpp

umbrello/codegenerators/php/php5writer.cpp

umbrello/codegenerators/php/phpwriter.cpp

umbrello/codegenerators/ruby/rubyclassifiercodedocument.cpp

umbrello/codegenerators/sql/sqlwriter.cpp

umbrello/codegenerators/textblock.h

umbrello/codegenerators/vala/valawriter.cpp

umbrello/codegenerators/xml/xmlschemawriter.h

umbrello/codegenerators/xml/xmlschemawriter.cpp

umbrello/codeimport/csharp/csharpimport.cpp

umbrello/codeimport/import_utils.h

umbrello/codeimport/import_utils.cpp

umbrello/codeimport/javaimport.cpp

umbrello/diagram_utils.cpp

umbrello/dialogs/codeeditor.cpp

umbrello/docgenerators/xhtmlgenerator.cpp

umbrello/toolbarstatemessages.h

umbrello/uml.cpp

umbrello/uml1model/association.cpp

umbrello/uml1model/foreignkeyconstraint.cpp

umbrello/umldoc.cpp

umbrello/umllistview.cpp

umbrello/umlscene.cpp

umbrello/umlwidgets/activitywidget.cpp

umbrello/umlwidgets/artifactwidget.h

umbrello/umlwidgets/artifactwidget.cpp

umbrello/umlwidgets/associationwidget.cpp

umbrello/umlwidgets/diagramproxywidget.cpp

umbrello/umlwidgets/objectnodewidget.cpp

umbrello/umlwidgets/objectwidget.h

umbrello/umlwidgets/widget_utils.cpp

umbrello/umlwidgets/widgetbase.cpp

unittests/testbase.cpp

Typo fixes for umbrello
ClosedPublic
Actions

Revision Contents
Changeset List