Make the loading closer to the reference impl
ClosedPublic

Authored by ervin on Aug 19 2015, 7:43 PM.

Details

Summary

We mainly change two pieces of behavior in that commit:
a) we make sure to not reuse ids which could be already used in the data
set when load is called;
b) we go through the collections (and allocate their id) in width first
and not in depth first.

This way we allocate the collection ids in the same order than akonaditest
from the same XML. It will be useful later on for the acceptance tests.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 583.Aug 19 2015, 7:43 PM
ervin retitled this revision from to Make the loading closer to the reference impl.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot, remibenoit.
ervin updated this revision to Diff 588.Aug 20 2015, 11:08 AM

Clarify a bit the description to highlight the motives behind this patch

ervin updated this object.Aug 20 2015, 11:10 AM
bensi added inline comments.Aug 20 2015, 11:12 AM
tests/testlib/akonadifakedataxmlloader.cpp
58–79

the foreach is done twice, one time here and one time line 79, why ?

bensi added inline comments.Aug 20 2015, 11:22 AM
tests/testlib/akonadifakedataxmlloader.cpp
83–84

the foreach is done twice, one time here and one time line 79, why ?

bensi edited edge metadata.Aug 20 2015, 11:23 AM
ervin updated this revision to Diff 589.Aug 20 2015, 11:34 AM
ervin edited edge metadata.

Merge the two loops

bensi accepted this revision.Aug 20 2015, 11:40 AM
bensi edited edge metadata.
This revision is now accepted and ready to land.Aug 20 2015, 11:40 AM
This revision was automatically updated to reflect the committed changes.