Differential D25722

Replace upload service with purpose plugin
ClosedPublic
Actions

Authored by nicolasfella on Dec 3 2019, 9:23 PM.

Details

Reviewers
volt4ire
scarpino
Group Reviewers
Choqok
Maniphest Tasks
T12256: Deprecate service based KFileItemAction plugin loading
Commits
R186:0b524cdf80d1: Replace upload service with purpose plugin
Summary

Purpose is the modern way of doing this. This will make the upload action show up in Dolphin's (and other apps) Share menu.

Test Plan

Trigger share from Dolphin

Diff Detail

Repository
R186 Choqok
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Dec 3 2019, 9:23 PM
nicolasfella created this revision.
nicolasfella added a reviewer: Choqok.Dec 3 2019, 9:24 PM
nicolasfella edited the summary of this revision. (Show Details)
scarpino added a comment.Dec 4 2019, 8:22 AM

Thank you for this!

CMakeLists.txt
41

Please don't make it required.

plugins/CMakeLists.txt
7

This should only be built if purpose is installed.

nicolasfella updated this revision to Diff 70909.Dec 4 2019, 3:48 PM
nicolasfella marked 2 inline comments as done.
  • Make Purpose optional
scarpino added inline comments.Dec 4 2019, 4:16 PM
plugins/CMakeLists.txt
25

May you please use KF5Purpose_FOUND instead? And also please show a message that this plugin will be built.

nicolasfella marked an inline comment as done.Jan 12 2020, 4:59 PM
scarpino requested changes to this revision.Jan 14 2020, 12:40 PM
scarpino added inline comments.
plugins/purpose/purposeplugin.cpp
21

Do we need this include here?

24

Do we need this include here?

This revision now requires changes to proceed.Jan 14 2020, 12:40 PM
nicolasfella updated this revision to Diff 73560.Jan 14 2020, 6:58 PM
  • Remove includes
scarpino accepted this revision.Feb 4 2020, 9:13 PM

Thanks!

This revision is now accepted and ready to land.Feb 4 2020, 9:13 PM
Closed by commit R186:0b524cdf80d1: Replace upload service with purpose plugin (authored by nicolasfella, committed by scarpino). · Explain WhyFeb 4 2020, 9:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75020

View Options

CMakeLists.txt

Loading...
View Options

plugins/CMakeLists.txt

Loading...
View Options

plugins/konqueror/CMakeLists.txt

Loading...
View Options

plugins/konqueror/choqok_upload.desktop

Loading...
View Options

plugins/purpose/CMakeLists.txt

Loading...
View Options

plugins/purpose/org.kde.choqok.xml

Loading...
View Options

plugins/purpose/purposeplugin.cpp

Loading...
View Options

plugins/purpose/purposeplugin.json

Loading...