Import the address editor from kdepim-addons
ClosedPublic
Actions

Authored by vkrause on Oct 29 2019, 5:42 PM.

Details

Reviewers

Commits

R459:9dc3ee966e61: Import the address editor from kdepim-addons

Summary

It's such a basic feature it shouldn't be an add-on. The main reason this
ended up in kdepim-addons was its dependency on WebEngine for the list
of addresses. That is a bit overkill and resulted in sub-optimal display
e.g. with dark color schemes. Therefore this part has now been replaced by
a regular item view widget.

Diff Detail

Repository

R459 Akonadi Contacts

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Oct 29 2019, 5:42 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 29 2019, 5:42 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

vkrause requested review of this revision.Oct 29 2019, 5:42 PM

Harbormaster completed remote builds in B18319: Diff 68990.Oct 29 2019, 5:42 PM

vkrause mentioned this in D25051: Remove the address editor plugin.Oct 29 2019, 5:44 PM

There was some autotests in kdepim-addons it will good to readd them for example addresslocationwidgettest.cpp

src/contact-editor/editor/addresseditor/addresseslocationwidget.h
48	nullptr

mlaurent requested changes to this revision.Oct 30 2019, 6:01 AM

This revision now requires changes to proceed.Oct 30 2019, 6:01 AM

Address review comments.

Harbormaster completed remote builds in B18373: Diff 69069.Oct 30 2019, 5:24 PM

mlaurent accepted this revision.Oct 31 2019, 5:50 AM

This revision is now accepted and ready to land.Oct 31 2019, 5:50 AM

Closed by commit R459:9dc3ee966e61: Import the address editor from kdepim-addons (authored by vkrause). · Explain WhyOct 31 2019, 6:58 PM

This revision was automatically updated to reflect the committed changes.

vkrause mentioned this in R81:344b6fc54951: Remove the address editor plugin.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (1 line)
M		src/contact-editor/CMakeLists.txt (20 lines)
P		src/contact-editor/editor/addresseditor/abstractaddresslocationwidget.h Deleted after being copied to multiple locations: src/contact-editor/editor/addresseditor/addressdelegate.h src/contact-editor/editor/addresseditor/addresstypedialog.h
V		src/contact-editor/editor/addresseditor/{abstractaddresslocationwidget.cpp → autotests/addresslocationwidgettest.h}
P		src/contact-editor/editor/addresseditor/addressdelegate.h (27 lines) Copied from src/contact-editor/editor/addresseditor/abstractaddresslocationwidget.h
A	M	src/contact-editor/editor/addresseditor/addressdelegate.cpp (66 lines)
P		src/contact-editor/editor/addresseditor/addresseslocationwidget.h (16 lines) Copied to multiple locations: src/contact-editor/editor/addresseditor/addressmodel.h src/contact-editor/editor/addresseditor/selectaddresstypecombobox.h
M		src/contact-editor/editor/addresseditor/addresseslocationwidget.cpp (107 lines)
A	M	src/contact-editor/editor/addresseditor/addresslocationwidget.h (91 lines)
A	M	src/contact-editor/editor/addresseditor/addresslocationwidget.cpp (296 lines)
P		src/contact-editor/editor/addresseditor/addressmodel.h (39 lines) Copied from src/contact-editor/editor/addresseditor/addresseslocationwidget.h
A	M	src/contact-editor/editor/addresseditor/addressmodel.cpp (106 lines)
V		src/contact-editor/editor/addresseditor/{addresstypedialog.h ← abstractaddresslocationwidget.h} (34 lines)
A	M	src/contact-editor/editor/addresseditor/addresstypedialog.cpp (94 lines)
A	M	src/contact-editor/editor/addresseditor/autotests/CMakeLists.txt (10 lines)
V		src/contact-editor/editor/addresseditor/{autotests/addresslocationwidgettest.h ← abstractaddresslocationwidget.cpp} (37 lines)
A	M	src/contact-editor/editor/addresseditor/autotests/addresslocationwidgettest.cpp (123 lines)
P		src/contact-editor/editor/addresseditor/selectaddresstypecombobox.h (58 lines) Copied from src/contact-editor/editor/addresseditor/addresseslocationwidget.h
A	M	src/contact-editor/editor/addresseditor/selectaddresstypecombobox.cpp (116 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	68990	63454cd		Oct 29 2019, 5:42 PM	★	★
Diff 2	69069	63454cd	Address review comments.	Oct 30 2019, 5:24 PM	★	★
Diff 3	69132	63454cd	R459:9dc3ee966e612f2844aa03d8f9e4ff8335205523	Oct 31 2019, 6:56 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
767ecb002c18	a93b3742c973	63454cd39cdd	Volker Krause	Import the address editor from kdepim-addons (Show More…)	Oct 29 2019, 5:41 PM

Import the address editor from kdepim-addonsClosedPublicActions

Details

Diff Detail

nullptr

Revision ContentsChangeset List

Diff 69132

CMakeLists.txt

src/contact-editor/CMakeLists.txt

src/contact-editor/editor/addresseditor/abstractaddresslocationwidget.h

src/contact-editor/editor/addresseditor/abstractaddresslocationwidget.cpp

src/contact-editor/editor/addresseditor/addressdelegate.h

src/contact-editor/editor/addresseditor/addressdelegate.cpp

src/contact-editor/editor/addresseditor/addresseslocationwidget.h

src/contact-editor/editor/addresseditor/addresseslocationwidget.cpp

src/contact-editor/editor/addresseditor/addresslocationwidget.h

src/contact-editor/editor/addresseditor/addresslocationwidget.cpp

src/contact-editor/editor/addresseditor/addressmodel.h

src/contact-editor/editor/addresseditor/addressmodel.cpp

src/contact-editor/editor/addresseditor/addresstypedialog.h

src/contact-editor/editor/addresseditor/addresstypedialog.cpp

src/contact-editor/editor/addresseditor/autotests/CMakeLists.txt

src/contact-editor/editor/addresseditor/autotests/addresslocationwidgettest.h

src/contact-editor/editor/addresseditor/autotests/addresslocationwidgettest.cpp

src/contact-editor/editor/addresseditor/selectaddresstypecombobox.h

src/contact-editor/editor/addresseditor/selectaddresstypecombobox.cpp

Import the address editor from kdepim-addons
ClosedPublic
Actions

Revision Contents
Changeset List