Differential D25036

Don't double format spreadsheet currency values with custom format strings.
ClosedPublic
Actions

Authored by denexter on Oct 29 2019, 7:05 AM.

Details

Reviewers
pvuorela
Commits
R8:44e297458950: Don't double format spreadsheet currency values with custom format strings.
Summary

If there is a format string for a currency value only format the number and let the format string append or prepend the appropriate currency symbol.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
denexter created this revision.Oct 29 2019, 7:05 AM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptOct 29 2019, 7:05 AM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
denexter requested review of this revision.Oct 29 2019, 7:05 AM
denexter added a reviewer: pvuorela.
pvuorela accepted this revision.Nov 6 2019, 1:15 PM

Seems good.

This revision is now accepted and ready to land.Nov 6 2019, 1:15 PM
Closed by commit R8:44e297458950: Don't double format spreadsheet currency values with custom format strings. (authored by denexter, committed by pvuorela). · Explain WhyNov 11 2019, 9:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msheets/ValueFormatter.cpp (6 lines)

Diff 69571

View Options

sheets/ValueFormatter.cpp

Loading...