Fix Install of kdepaths.py on Windows
Needs ReviewPublic

Authored by twighk on Oct 28 2019, 8:45 PM.

Details

Reviewers
None
Group Reviewers
KDE Games
Summary

kdepaths is generated from src/kdepaths.py.in (in CMakeLists.txt), and when installed on windows is given an absolute path, rather than a relative one.

When doing the byte compile and install (the top change), the _basepath of kdepaths.py already includes the ${CMAKE_CURRENT_BINARY_DIR}, and this results in it trying to make a ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CURRENT_BINARY_DIR}/... directory (i.e. C:/somestuff/C:/somestuff)

When doing the file copy (the bottom change), $ENV{DESTDIR} is blank and results in it trying to copy files into /C:/... , which upsets windows.

Diff Detail

Repository
R387 Kajongg
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18273
Build 18291: arc lint + arc unit
twighk created this revision.Oct 28 2019, 8:45 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptOct 28 2019, 8:45 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
twighk requested review of this revision.Oct 28 2019, 8:45 PM
twighk edited the summary of this revision. (Show Details)Oct 28 2019, 9:08 PM
twighk edited the summary of this revision. (Show Details)Oct 29 2019, 7:41 AM