[GTK3] Revert checkbox recolouring
ClosedPublic
Actions

Authored by cblack on Oct 28 2019, 2:02 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

This reverts the effects of commit 7b3d0777ea6c10dd430ed686434d3a4e2d072632 and some effects of commit 987f750ea16a6f82d29cd6504a69d93575c895d4,
meaning that checkboxes and radiobuttons will no longer attempt to follow the colourscheme.

This is necessary because the facilities used to recolour checkboxes are now glitchy in GTK
and result in usability issues. See https://gitlab.gnome.org/GNOME/gtk/issues/2217

BUG: 412078
FIXED-IN: 5.17.2

Test Plan

Repository

R98 Breeze for Gtk

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

cblack requested review of this revision.Oct 28 2019, 2:02 AM

cblack edited the test plan for this revision. (Show Details)Oct 28 2019, 2:03 AM

ngraham edited the summary of this revision. (Show Details)

Sad that it has to come to this. Maybe they'll fix the bug in GTK eventually. :/

5.17 branch please (after running arc amend on your local branch so that it picks up the change I made to add the BUG: tag).

This revision is now accepted and ready to land.Oct 28 2019, 3:01 AM

Reverse checkboxes in menus as well

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/gtk3/widgets/_checkboxes.scss (92 lines)
M			src/gtk3/widgets/_menus.scss (29 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	68863	5c1a58b		Oct 28 2019, 2:02 AM	★	★
Diff 2	68934	5c1a58b	Reverse checkboxes in menus as well	Oct 29 2019, 12:04 AM	★	★
Diff 3	68936	16d0084	R98:b1649126c8c6d1af746a8472939fcda40a260095	Oct 29 2019, 12:26 AM	★	★