Improve explanation of table filter/search
ClosedPublic

Authored by spage on Oct 27 2019, 8:30 AM.

Details

Reviewers
smankowski
Summary

Minor text improvements

Test Plan

Build docs, look at Chapter 2. Main concepts (main-concepts.html) , decide if it's any better.

Diff Detail

Repository
R469 Skrooge
Lint
Lint Skipped
Unit
Unit Tests Skipped
spage created this revision.Oct 27 2019, 8:30 AM
Restricted Application added a project: Documentation. · View Herald TranscriptOct 27 2019, 8:30 AM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
spage requested review of this revision.Oct 27 2019, 8:30 AM
smankowski accepted this revision.Oct 27 2019, 8:55 AM
smankowski added a subscriber: smankowski.

You can commit it

This revision is now accepted and ready to land.Oct 27 2019, 8:55 AM
spage added a comment.Oct 30 2019, 9:14 AM

You can commit it

Thanks, but how? Action > Close revision in this UI doesn't sound like "landing," and I get a weird internal curl error when I try to set up Arcanist. Can I just git push?

You can commit it

Thanks, but how? Action > Close revision in this UI doesn't sound like "landing," and I get a weird internal curl error when I try to set up Arcanist. Can I just git push?

Yes. But do not forget to add a separate line with

Differential Revision: https://phabricator.kde.org/D24977

into your commit message to close this revision.

smankowski closed this revision.Oct 30 2019, 7:41 PM

I did the commit