Differential D24812

Don't link against KF5::IconThemes where we don't use it at all
ClosedPublic
Actions

Authored by vkrause on Oct 20 2019, 7:15 PM.

Tags

Subscribers

Details

Reviewers

Commits

R81:9e7b2a562595: Don't link against KF5::IconThemes where we don't use it at all

Diff Detail

Repository

R81 KDE PIM Addons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Oct 20 2019, 7:15 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 20 2019, 7:15 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

vkrause requested review of this revision.Oct 20 2019, 7:15 PM

Harbormaster completed remote builds in B17947: Diff 68385.Oct 20 2019, 7:15 PM

mlaurent accepted this revision.Oct 20 2019, 8:38 PM

This revision is now accepted and ready to land.Oct 20 2019, 8:38 PM

Closed by commit R81:9e7b2a562595: Don't link against KF5::IconThemes where we don't use it at all (authored by vkrause). · Explain WhyOct 20 2019, 8:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			examples/apps/mailreader/CMakeLists.txt (1 line)
M			kmail/editorconvertertextplugins/markdown/autotests/CMakeLists.txt (2 lines)
M			kmail/editorconvertertextplugins/markdown/markdownlib/CMakeLists.txt (1 line)
M			kmail/editorinitplugins/externalcomposer/CMakeLists.txt (2 lines)
M			kmail/editorinitplugins/externalcomposer/autotests/CMakeLists.txt (2 lines)
M			kmail/editorplugins/autocorrection/CMakeLists.txt (2 lines)
M			kmail/editorplugins/autocorrection/autotests/CMakeLists.txt (2 lines)
M			kmail/editorplugins/changecase/CMakeLists.txt (2 lines)
M			kmail/editorplugins/changecase/autotests/CMakeLists.txt (2 lines)
M			kmail/editorplugins/insertemail/CMakeLists.txt (2 lines)
M			kmail/editorplugins/insertemail/autotests/CMakeLists.txt (2 lines)
M			kmail/editorplugins/insertshorturl/CMakeLists.txt (2 lines)
M			kmail/editorplugins/insertshorturl/autotests/CMakeLists.txt (2 lines)
M			kmail/editorplugins/insertspecialcharacter/CMakeLists.txt (2 lines)
M			kmail/editorplugins/insertspecialcharacter/autotests/CMakeLists.txt (2 lines)
M			kmail/editorplugins/nonbreakingspace/CMakeLists.txt (2 lines)
M			kmail/editorplugins/nonbreakingspace/autotests/CMakeLists.txt (2 lines)
M			kmail/editorplugins/quicktext/CMakeLists.txt (2 lines)
M			kmail/editorplugins/quicktext/autotests/CMakeLists.txt (2 lines)
M			kmail/editorplugins/sharetext/CMakeLists.txt (2 lines)
M			kmail/editorplugins/sharetext/autotests/CMakeLists.txt (2 lines)
M			kmail/editorplugins/zoomtext/CMakeLists.txt (2 lines)
M			kmail/editorplugins/zoomtext/autotests/CMakeLists.txt (2 lines)
M			kmail/editorsendcheckplugins/automaticaddcontacts/CMakeLists.txt (2 lines)
M			kmail/editorsendcheckplugins/automaticaddcontacts/autotests/CMakeLists.txt (12 lines)
M			kmail/editorsendcheckplugins/checkbeforesend/CMakeLists.txt (2 lines)
M			kmail/editorsendcheckplugins/checkbeforesend/autotests/CMakeLists.txt (2 lines)
M			kmail/editorsendcheckplugins/confirm-address/CMakeLists.txt (2 lines)
M			kmail/editorsendcheckplugins/confirm-address/autotests/CMakeLists.txt (2 lines)
M			kmail/grammarplugins/grammalecte/autotests/CMakeLists.txt (2 lines)
M			kmail/grammarplugins/grammalecte/plugin/CMakeLists.txt (2 lines)
M			kmail/grammarplugins/grammalecte/src/CMakeLists.txt (1 line)
M			kmail/grammarplugins/grammarcommon/autotests/CMakeLists.txt (2 lines)
M			kmail/grammarplugins/languagetool/autotests/CMakeLists.txt (2 lines)
M			kmail/grammarplugins/languagetool/plugin/CMakeLists.txt (2 lines)
M			kmail/grammarplugins/languagetool/src/CMakeLists.txt (1 line)
M			kmail/plugins/expertplugin/CMakeLists.txt (2 lines)
M			kmail/plugins/logactivitiesplugin/CMakeLists.txt (2 lines)
M			kmail/plugins/logactivitiesplugin/autotests/CMakeLists.txt (2 lines)

Diff 68390

examples/apps/mailreader/CMakeLists.txt

Loading...

kmail/editorconvertertextplugins/markdown/autotests/CMakeLists.txt

Loading...

kmail/editorconvertertextplugins/markdown/markdownlib/CMakeLists.txt

Loading...

kmail/editorinitplugins/externalcomposer/CMakeLists.txt

Loading...

kmail/editorinitplugins/externalcomposer/autotests/CMakeLists.txt

Loading...

kmail/editorplugins/autocorrection/CMakeLists.txt

Loading...

kmail/editorplugins/autocorrection/autotests/CMakeLists.txt

Loading...

kmail/editorplugins/changecase/CMakeLists.txt

Loading...

kmail/editorplugins/changecase/autotests/CMakeLists.txt

Loading...

kmail/editorplugins/insertemail/CMakeLists.txt

Loading...

kmail/editorplugins/insertemail/autotests/CMakeLists.txt

Loading...

kmail/editorplugins/insertshorturl/CMakeLists.txt

Loading...

kmail/editorplugins/insertshorturl/autotests/CMakeLists.txt

Loading...

kmail/editorplugins/insertspecialcharacter/CMakeLists.txt

Loading...

kmail/editorplugins/insertspecialcharacter/autotests/CMakeLists.txt

Loading...

kmail/editorplugins/nonbreakingspace/CMakeLists.txt

Loading...

kmail/editorplugins/nonbreakingspace/autotests/CMakeLists.txt

Loading...

kmail/editorplugins/quicktext/CMakeLists.txt

Loading...

kmail/editorplugins/quicktext/autotests/CMakeLists.txt

Loading...

kmail/editorplugins/sharetext/CMakeLists.txt

Loading...

kmail/editorplugins/sharetext/autotests/CMakeLists.txt

Loading...

kmail/editorplugins/zoomtext/CMakeLists.txt

Loading...

kmail/editorplugins/zoomtext/autotests/CMakeLists.txt

Loading...

kmail/editorsendcheckplugins/automaticaddcontacts/CMakeLists.txt

Loading...

kmail/editorsendcheckplugins/automaticaddcontacts/autotests/CMakeLists.txt

Loading...

kmail/editorsendcheckplugins/checkbeforesend/CMakeLists.txt

Loading...

kmail/editorsendcheckplugins/checkbeforesend/autotests/CMakeLists.txt

Loading...

kmail/editorsendcheckplugins/confirm-address/CMakeLists.txt

Loading...

kmail/editorsendcheckplugins/confirm-address/autotests/CMakeLists.txt

Loading...

kmail/grammarplugins/grammalecte/autotests/CMakeLists.txt

Loading...

kmail/grammarplugins/grammalecte/plugin/CMakeLists.txt

Loading...

kmail/grammarplugins/grammalecte/src/CMakeLists.txt

Loading...

kmail/grammarplugins/grammarcommon/autotests/CMakeLists.txt

Loading...

kmail/grammarplugins/languagetool/autotests/CMakeLists.txt

Loading...

kmail/grammarplugins/languagetool/plugin/CMakeLists.txt

Loading...

kmail/grammarplugins/languagetool/src/CMakeLists.txt

Loading...

kmail/plugins/expertplugin/CMakeLists.txt

Loading...

kmail/plugins/logactivitiesplugin/CMakeLists.txt

Loading...

kmail/plugins/logactivitiesplugin/autotests/CMakeLists.txt

Loading...