Differential D24638

KOrganizer Month View: remove comma in Year
ClosedPublic
Actions

Authored by winterz on Oct 14 2019, 4:41 PM.

Details

Reviewers
mlaurent
Commits
R76:a5c067fbc83c: month/monthscene.cpp - remove comma in year (in the title)
Summary

fix bug Monthview shows comma in year
https://bugs.kde.org/show_bug.cgi?id=412833

Test Plan

Before this patch the month view title said "October 2,109"
Now it says "October 2019"

Diff Detail

Repository
R76 PIM: Event Views
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
winterz created this revision.Oct 14 2019, 4:41 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 14 2019, 4:41 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
winterz requested review of this revision.Oct 14 2019, 4:41 PM
mlaurent accepted this revision.Oct 15 2019, 4:59 AM
This revision is now accepted and ready to land.Oct 15 2019, 4:59 AM
Closed by commit R76:a5c067fbc83c: month/monthscene.cpp - remove comma in year (in the title) (authored by winterz). · Explain WhyOct 15 2019, 1:06 PM
This revision was automatically updated to reflect the committed changes.
winterz added a comment.Oct 17 2019, 1:04 PM

I'm not sure I like this code.

wouldn't it be better to use QString QDate::toString("%MMMM %YYYY")
and then we get localization and stuff.

Revision Contents
Changeset List

PathPackages
Msrc/month/monthscene.cpp (6 lines)

Diff 67974

View Options

src/month/monthscene.cpp

Loading...