Differential D2452

Simplify and fix sizing code in ToolTipDelegate
AbandonedPublic
Actions

Authored by davidedmundson on Aug 15 2016, 2:22 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Row's implicitWidth is already set to the width of the children.
Using childrenRect results in more evaluations, and an apparent binding
loop when RTL layouts are used.

Test Plan

Ran plasmashell --reverse with Kai's patch and nothing froze
Ran normally and everything looks the same

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson updated this revision to Diff 5941.Aug 15 2016, 2:22 PM
davidedmundson retitled this revision from to Simplify and fix sizing code in ToolTipDelegate.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 15 2016, 2:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson abandoned this revision.Aug 15 2016, 2:26 PM

Revision Contents
Changeset List

Diff 5941

View Options

applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

Loading...