Fix build with cmake < 3.7
ClosedPublic

Authored by wbauer on Sep 1 2019, 11:27 AM.

Details

Summary

GREATER_EQUAL was introduced in cmake 3.7, but the specified minimum version is 2.8.11.
So use NOT LESS instead to still support older cmake versions too.

Test Plan

Builds fine with cmake 3.5.2 now, and also newer versions (haven't tried older versions).

Before, I got this error when building umbrello master or 19.08.0 with cmake 3.5.2:

CMake Error at CMakeLists.txt:12 (if):
  if given arguments:

    "KDE_APPLICATIONS_VERSION_MICRO" "GREATER_EQUAL" "70"

  Unknown arguments specified

Diff Detail

Repository
R139 Umbrello
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wbauer created this revision.Sep 1 2019, 11:27 AM
Restricted Application added a subscriber: umbrello-devel. · View Herald TranscriptSep 1 2019, 11:27 AM
wbauer requested review of this revision.Sep 1 2019, 11:27 AM
wbauer added a reviewer: Umbrello.
habacker accepted this revision.Sep 2 2019, 5:57 AM
This revision is now accepted and ready to land.Sep 2 2019, 5:57 AM
This revision was automatically updated to reflect the committed changes.