Add a self-timer

Authored by pettke on Aug 18 2019, 3:50 AM.



Adds a self timer with the options off, 2 s, 5 s 10 s and 20 s.
It can be used in photo and video mode.

When the self-timer is running, a countown and a flashing red border
are shown, the capture/recording action changes to a cancel action.

The functionality of the onTriggered handler of the captureAction has
been moved to the onTriggered handler of the selfTimer.

Diff Detail

R24 Plasma Mobile: Camera Application
self-timer (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 15261
Build 15279: arc lint + arc unit
pettke requested review of this revision.Aug 18 2019, 3:50 AM
pettke created this revision.
jbbgameich requested changes to this revision.Aug 18 2019, 9:26 AM
jbbgameich added a subscriber: jbbgameich.

Looks and works great! I especially like the animations. After the the minor coding style change it is ready to land in my opinion.

For future patches, please note that we have moved to, but for now the patch can easily be landed on the invent repository even if posted on phabricator.


This could be written shorter

selfTimer.running ? "red" : "white"
This revision now requires changes to proceed.Aug 18 2019, 9:26 AM
pettke updated this revision to Diff 63982.Aug 18 2019, 7:05 PM

shorten selfTimerIcon color definition

pettke marked an inline comment as done.Aug 18 2019, 7:08 PM

Are there any special steps required to land it on the invent repository?

I don't think I have a developer account, so I am not sure if I can land anything at all.

I can land the patch for you. In the future, you can create a merge request on invent instead of a phabricator patch.
Thanks for your contribution :)

jbbgameich accepted this revision.Aug 18 2019, 7:35 PM
This revision is now accepted and ready to land.Aug 18 2019, 7:35 PM
jbbgameich closed this revision.Aug 18 2019, 7:36 PM

Thanks as well :)

Is there a preferred channel for discussions about the camera app? Besides the general plasma mobile ones I have only found this Phabricator task so far.

jbbgameich added a comment.EditedAug 22 2019, 5:36 AM

For other project todo / tasks you could use the issues on
If you want something chat-like, feel free to use the Plasma Mobile channels also for the camera app.