Fix memory leak when deleting MessageViewer and its NodeHelper.
ClosedPublic
Actions

Authored by dfaure on Jul 31 2016, 6:57 PM.

Details

Reviewers

Commits

Summary

The Interface::BodyPartMemento(s) were not deleted.

Since they are deleted when switching messages, this is no severe
leak, it just showed up in a unittest.

Test Plan

qDebug in ctor/dtor, from unittest.
Running kmail still works.

Repository

R94 PIM: Message Library

Branch

messagelib-memleak

Lint

No Linters Available

Unit

No Unit Test Coverage

dfaure retitled this revision from to Fix memory leak when deleting MessageViewer and its NodeHelper..

dfaure updated this object.

dfaure edited the test plan for this revision. (Show Details)

dfaure added a reviewer: mlaurent.

dfaure added a subscriber: KDE PIM.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

Seems ok for me.
Thanks.

This revision is now accepted and ready to land.Jul 31 2016, 7:14 PM

			Path	Packages
M			mimetreeparser/src/viewer/nodehelper.cpp (1 line)

Commit	Tree	Parents	Author	Summary	Date
00283cb1f050	3edc7263a81f	2ee5bc147480	David Faure	Fix memory leak when deleting MessageViewer and its NodeHelper. (Show More…)	Jul 31 2016, 5:43 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5588	2ee5bc1		Jul 31 2016, 6:57 PM	★	★