Fix compilation with Kdevelop 5.4
ClosedPublic

Authored by pavelp on Aug 9 2019, 6:03 AM.

Details

Reviewers
None
Group Reviewers
KDevelop
Commits
R59:6aee7c564ae3: Fix compilation with Kdevelop 5.4

Diff Detail

Repository
R59 KDevelop Go
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pavelp created this revision.Aug 9 2019, 6:03 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptAug 9 2019, 6:03 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
pavelp requested review of this revision.Aug 9 2019, 6:03 AM

@pavelp Hi from a more recent contributor to KDevelop, good to see you back again once more and care for your former work :)

Cannot comment on the changes beyond syntax (no Go coder myself), where they seem fine. So if you are confident with them and they work for you, please ship them (I assume you still have push rights to KDE repos?). Or tell and I would do for you (in that case, which autor name & email address to use in the commit metadata?).

We recently tagged the kdevelop-go repo as unmaintained given no-one had cared for it in a while though. Thus also it got removed from KDE CI (https://build.kde.org/job/KDevelop/)). Do you have plans to work more on it?
Doing a release (as stand-alone plugin) might be also interesting once in a while, so distributions might be triggered to pick it up and ship to users, so more people might get in contact with it and become potential contributors.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2019, 9:34 PM
This revision was automatically updated to reflect the committed changes.

@pavelp Hi from a more recent contributor to KDevelop, good to see you back again once more and care for your former work :)

Hi, thank you, I'm happy to be back!

Cannot comment on the changes beyond syntax (no Go coder myself), where they seem fine. So if you are confident with them and they work for you, please ship them (I assume you still have push rights to KDE repos?). Or tell and I would do for you (in that case, which autor name & email address to use in the commit metadata?).

Looks like I still have them :)

We recently tagged the kdevelop-go repo as unmaintained given no-one had cared for it in a while though. Thus also it got removed from KDE CI (https://build.kde.org/job/KDevelop/)). Do you have plans to work more on it?
Doing a release (as stand-alone plugin) might be also interesting once in a while, so distributions might be triggered to pick it up and ship to users, so more people might get in contact with it and become potential contributors.

I don't think I will do any serious work on kdev-go as I don't use Go much anymore. But I'd like to keep in at least compilable state with the latest KDevelop so people can still check it out.