Merge LLDB plugin into master
ClosedPublic
Actions

Authored by qi437103 on Jul 27 2016, 1:04 AM.

Details

Reviewers

Group Reviewers

Commits

R32:d883c404b415: Remove unused code
R32:63e47f1d09df: Merge LLDB plugin into master
R32:457ee9f7d7b3: Remove non-existing mi command
R32:3d9809f31dbb: Update TODO for lldb plugin

Summary

LLDB plugin is now working for basic debugging use cases.

Things that work:

Basic execution control: start, continue, step etc.
Break points
Frame stack list
Symbol info when hover
Variables & Expressions (still have caveats)
Multi-threaded debugee (must use LLDB trunk version)
Debugger console
Remote debugging (only tested on localhost)

Things not working yet:

Disassembly/Register view
Memory view
Pending break points and anything requires pending break points
Watch points
Attach to process (works internally, no UI to access it)

Not tested:

Examine core file
Drkonqi support

There's a debugers/lldb/TODO.txt which contains more detailed description of current limitations and link to related LLDB bug reports.

Note: the whole thing might crash from time to time without this bug fixed. I'm using LLDB built myself with the code fixed. The patch can be found in the bug report.

Test Plan

GDB unit tests (such that I didn't break anything)
LLDB unit tests (some of them are skipped due to limitations mentioned above)
Manually tested

Diff Detail

Repository

R32 KDevelop

Branch

peifeng/lldb-plugin

Lint

No Linters Available

Unit

No Unit Test Coverage

qi437103 updated this revision to Diff 5511.Jul 27 2016, 1:04 AM

qi437103 retitled this revision from to Merge LLDB plugin into master.

qi437103 updated this object.

qi437103 edited the test plan for this revision. (Show Details)

qi437103 added reviewers: apol, KDevelop.

qi437103 set the repository for this revision to R32 KDevelop.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 27 2016, 1:04 AM

qi437103 updated this object.Jul 27 2016, 2:56 PM

debuggers/common/mi/micommand.cpp
286	What does that `non-exist command` mean? It only exists in gdb? On neither?
debuggers/common/midebuggerplugin.h
148	Please don't leave commented, boilerplate, code.
debuggers/lldb/TODO.txt
103	Mention attach to process debugging at least?

Address inline comments

debuggers/common/mi/micommand.cpp
286	It doesn't exist in neither gdb or lldb.

Make GDB and LLDB plugin load/unload tool views with debug session
Update TODO

qi437103 updated this revision to Diff 5554.Jul 29 2016, 9:20 AM

In D2293#42996, @qi437103 wrote:

Address inline comments

It doesn't exist in neither gdb or lldb.

Any reason why we shouldn't just remove them?

Yep, we can safely remove them. It's just that at the time when I added comments, I was not sure whether there's any side effect removing them. But now I can say they are just no use.

Remove non-existing MI commands

Closed by commit R32:3d9809f31dbb: Update TODO for lldb plugin (authored by qi437103). · Explain WhyJul 29 2016, 1:16 PM

This revision was automatically updated to reflect the committed changes.

Mistakenly closed

apol accepted this revision.Aug 1 2016, 12:41 AM

apol edited edge metadata.

This revision is now accepted and ready to land.Aug 1 2016, 12:41 AM

Closed by commit R32:63e47f1d09df: Merge LLDB plugin into master (authored by qi437103). · Explain WhyAug 1 2016, 6:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		debuggers/CMakeLists.txt (22 lines)
M		debuggers/common/CMakeLists.txt (9 lines)
M		debuggers/common/dbgglobal.h (39 lines)
M		debuggers/common/mi/micommand.cpp (96 lines)
M		debuggers/common/mi/miparser.cpp (5 lines)
M		debuggers/common/midebugger.cpp (34 lines)
M		debuggers/common/midebuggerplugin.h (18 lines)
M		debuggers/common/midebuggerplugin.cpp (38 lines)
M		debuggers/common/midebugjobs.cpp (14 lines)
M		debuggers/common/midebugsession.h (11 lines)
M		debuggers/common/midebugsession.cpp (51 lines)
M		debuggers/common/miframestackmodel.cpp (4 lines)
M		debuggers/common/mivariable.h (4 lines)
M		debuggers/common/mivariable.cpp (4 lines)
M		debuggers/common/mivariablecontroller.h (4 lines)
M		debuggers/common/mivariablecontroller.cpp (54 lines)
A	M	debuggers/common/widgets/debuggerconsoleview.h (157 lines)
A	M	debuggers/common/widgets/debuggerconsoleview.cpp (400 lines)
A	M	debuggers/common/widgets/debuggerconsoleview.ui (85 lines)
M		debuggers/common/widgets/disassemblewidget.h (2 lines)
M		debuggers/common/widgets/disassemblewidget.cpp (2 lines)
M		debuggers/gdb/CMakeLists.txt (18 lines)
M		debuggers/gdb/debuggerplugin.h (8 lines)
M		debuggers/gdb/debuggerplugin.cpp (45 lines)
M		debuggers/gdb/debugsession.h (8 lines)
M		debuggers/gdb/debugsession.cpp (42 lines)
M		debuggers/gdb/gdb.cpp (4 lines)
M		debuggers/gdb/gdbconfigpage.cpp (34 lines)
M		debuggers/gdb/unittests/CMakeLists.txt (1 line)
A	M	debuggers/gdb/unittests/debugeeechoenv.cpp (40 lines)
P		debuggers/gdb/unittests/test_gdb.h (1 line) Copied to debuggers/lldb/unittests/test_lldb.h
P		debuggers/gdb/unittests/test_gdb.cpp (86 lines) Copied to debuggers/lldb/unittests/test_lldb.cpp
A	M	debuggers/lldb/CMakeLists.txt (78 lines)
A	M	debuggers/lldb/Messages.sh (4 lines)
A	M	debuggers/lldb/TODO.txt (121 lines)
A	M	debuggers/lldb/controllers/breakpointcontroller.h (43 lines)
A	M	debuggers/lldb/controllers/breakpointcontroller.cpp (32 lines)
A	M	debuggers/lldb/controllers/framestackmodel.h (60 lines)
A	M	debuggers/lldb/controllers/framestackmodel.cpp (118 lines)
A	M	debuggers/lldb/controllers/variable.h (56 lines)
A	M	debuggers/lldb/controllers/variable.cpp (75 lines)
A	M	debuggers/lldb/controllers/variablecontroller.h (50 lines)
A	M	debuggers/lldb/controllers/variablecontroller.cpp (66 lines)
A	M	debuggers/lldb/debuggerplugin.h (66 lines)
A	M	debuggers/lldb/debuggerplugin.cpp (100 lines)
A	M	debuggers/lldb/debugsession.h (91 lines)
A	M	debuggers/lldb/debugsession.cpp (298 lines)
A	M	debuggers/lldb/kdevlldb.json (44 lines)
A	M	debuggers/lldb/kdevlldb.qrc (6 lines)
A	M	debuggers/lldb/kdevlldbui.rc (22 lines)
A	M	debuggers/lldb/lldbcommand.h (54 lines)
A	M	debuggers/lldb/lldbcommand.cpp (229 lines)
A	M	debuggers/lldb/lldbdebugger.h (46 lines)
A	M	debuggers/lldb/lldbdebugger.cpp (142 lines)
A	M	debuggers/lldb/lldblauncher.h (52 lines)
A	M	debuggers/lldb/lldblauncher.cpp (105 lines)
A	M	debuggers/lldb/unittests/debugees/CMakeLists.txt (21 lines)
A	M	debuggers/lldb/unittests/debugees/debugee space.cpp (23 lines)
A	M	debuggers/lldb/unittests/debugees/debugee.cpp (41 lines)
A	M	debuggers/lldb/unittests/debugees/debugeecrash.cpp (31 lines)
A	M	debuggers/lldb/unittests/debugees/debugeeechoenv.cpp (40 lines)
A	M	debuggers/lldb/unittests/debugees/debugeeexception.cpp (37 lines)
A	M	debuggers/lldb/unittests/debugees/debugeemultilocbreakpoint.cpp (35 lines)
A	M	debuggers/lldb/unittests/debugees/debugeemultiplebreakpoint.cpp (53 lines)
A	M	debuggers/lldb/unittests/debugees/debugeeqt.cpp (31 lines)
A	M	debuggers/lldb/unittests/debugees/debugeerecursion.cpp (32 lines)
A	M	debuggers/lldb/unittests/debugees/debugeeslow.cpp (37 lines)
A	M	debuggers/lldb/unittests/debugees/debugeethreads.cpp (42 lines)
A	M	debuggers/lldb/unittests/debugees/path with space/CMakeLists.txt (2 lines)
A	M	debuggers/lldb/unittests/debugees/path with space/spacedebugee.cpp (31 lines)
P		debuggers/lldb/unittests/test_lldb.h (130 lines) Copied from debuggers/gdb/unittests/test_gdb.h
P		debuggers/lldb/unittests/test_lldb.cpp (1914 lines) Copied from debuggers/gdb/unittests/test_gdb.cpp
A	M	debuggers/lldb/unittests/testhelper.h (69 lines)
A	M	debuggers/lldb/unittests/testhelper.cpp (169 lines)
A	M	debuggers/lldb/widgets/lldbconfigpage.h (56 lines)
A	M	debuggers/lldb/widgets/lldbconfigpage.cpp (121 lines)
A	M	debuggers/lldb/widgets/lldbconfigpage.ui (226 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5511	2f75898		Jul 27 2016, 12:51 AM	★	★
Diff 2	5553	2f75898		Jul 29 2016, 9:14 AM	★	★
Diff 3	5554	2f75898		Jul 29 2016, 9:19 AM	★	★
Diff 4	5557	2f75898		Jul 29 2016, 1:14 PM	★	★
Diff 5	5558	2d142a2	rKDEVELOP3d9809f31dbbd7b50547f3e64cee81e143a63268	Jul 29 2016, 9:14 AM	★	★
Diff 6	5594	44b8acc	rKDEVELOP63e47f1d09dfa793f34bca256d1e479d849fbd11	Aug 1 2016, 6:01 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
d883c404b415	cb240b1355ad	3d9809f31dbb	Peifeng Yu	Remove unused code	Jul 29 2016, 9:19 AM
3d9809f31dbb	06b82f8107d0	2d142a20c20d	Peifeng Yu	Update TODO for lldb plugin	Jul 29 2016, 9:14 AM
2d142a20c20d	7d2d0dc2ff30	ccc9c940b01f	Peifeng Yu	KDEvMI: avoid duplicating tool views by loading/unloading them with debug… (Show More…)	Jul 27 2016, 3:47 AM
ccc9c940b01f	65088236b8de	37188342fe0b	Peifeng Yu	KDevMI: fix MIDebugger logging category	Jul 27 2016, 12:50 AM
37188342fe0b	35163364d940	d5d085292dc5	Peifeng Yu	Fix broken gdb/lldb unit tests after merging	Jul 27 2016, 12:17 AM
d5d085292dc5	5124cdf34ed4	6a09d5ea8d61 2f758986eae5	Peifeng Yu	Merge remote-tracking branch 'origin/master' into peifeng/lldb-plugin	Jul 26 2016, 11:52 PM
6a09d5ea8d61	d7a333571660	dd7f1c90f4f0	Peifeng Yu	KDevMI: minor cleanup in MIDebugJob	Jul 26 2016, 3:29 PM
dd7f1c90f4f0	1ac43360bc34	b3fd416d1277	Peifeng Yu	KDevMI: correctly handle error in MIVariableController	Jul 26 2016, 5:10 AM
b3fd416d1277	77f06e4f10e8	645e55393fb2	Peifeng Yu	LLDB plugin: fix minor issue in lldb config page UI	Jul 26 2016, 4:58 AM
645e55393fb2	95c28f4a9b1e	c6c540d124f5	Peifeng Yu	LLDB plugin: fix setting variable format not work	Jul 26 2016, 4:48 AM
c6c540d124f5	ca3d40a8aa5e	95cd1f55fafb	Peifeng Yu	LLDB plugin: handle lldb specific case when querying disassembly-flavor	Jul 26 2016, 4:24 AM
95cd1f55fafb	bbb5dd7aadbe	29359e8d4fc2	Peifeng Yu	LLDB plugin: correctly show output when the user issues a MI command	Jul 26 2016, 4:23 AM
29359e8d4fc2	17e47515df46	2f4a65241cba	Peifeng Yu	LLDB plugin: polish debugger console (Show More…)	Jul 25 2016, 8:18 PM
2f4a65241cba	4b397e0ccf55	465e58fda259	Peifeng Yu	LLDB plugin: don't show interrupt button in debugger console	Jul 25 2016, 5:54 PM
465e58fda259	5e11e6d0ae32	8abf2d0cf52d	Peifeng Yu	LLDB plugin: make debugger console work and some minor fix	Jul 25 2016, 5:48 PM
8abf2d0cf52d	621cd23638eb	c02581d9bda8 db45e8687187	Peifeng Yu	Merge remote-tracking branch 'origin/master' into peifeng/lldb-plugin	Jul 20 2016, 3:21 PM
c02581d9bda8	8c3d85738bb1	a12ef6b2cdda	Peifeng Yu	Fix license header	Jul 18 2016, 3:33 AM
a12ef6b2cdda	299e377b4303	8e25f4ee0567	Peifeng Yu	Make debugger not confused when user command starts with digits	Jul 18 2016, 3:30 AM
8e25f4ee0567	d7ca696cc24d	b90eb8c2a21c	Peifeng Yu	Reworked LLDB Debugger Console	Jul 18 2016, 3:30 AM
b90eb8c2a21c	57757f5d725b	a6c4b950ae4f	Peifeng Yu	Add unit test for remote debugging for lldb	Jul 17 2016, 5:51 AM
a6c4b950ae4f	b05ad4d07901	49e0b8efd8a4	Peifeng Yu	Finish ConfigPage and LldbLauncher. One can use LLDB plugin doing basic… (Show More…)	Jul 17 2016, 5:40 AM
49e0b8efd8a4	7625fd9917b6	07f3ba94b37f	Peifeng Yu	Partial implementation of LldbDebuggerPlugin class	Jul 16 2016, 5:33 AM
07f3ba94b37f	f834825bec3b	e0fdc4fc96ba	Peifeng Yu	Lldb config page and launcher	Jul 16 2016, 5:14 AM
e0fdc4fc96ba	45f2dd736087	44e9a1433206	Peifeng Yu	More clear seprate between gdb and lldb config entries	Jul 16 2016, 3:49 AM
44e9a1433206	748ec05729b6	512e39aa9a3c	Peifeng Yu	Workaround for lldb tty setting on linux	Jul 15 2016, 6:27 PM
512e39aa9a3c	d547548cdb0d	77ef011a3a72 9cb910b95eee	Peifeng Yu	Merge remote-tracking branch 'origin/master' into peifeng/lldb-plugin	Jul 15 2016, 5:34 PM
77ef011a3a72	af5abf8b7e14	77698ceb039e	Peifeng Yu	Move environment var settings into debugger specific code	Jul 14 2016, 5:57 PM
77698ceb039e	8f98ede1234f	eba261119007	Peifeng Yu	Use qCWarning instead of qCDebug	Jul 13 2016, 10:08 PM
eba261119007	5b324651cc1c	c389b3d79b75	Peifeng Yu	Add unit test about environment variable for lldb plugin	Jul 13 2016, 9:48 PM
c389b3d79b75	172eb4048b5e	2fc030cb8064	Peifeng Yu	Add explicit dependencies for lldb_test and make kdevelop happy when editing… (Show More…)	Jul 13 2016, 9:46 PM
2fc030cb8064	e8436a281b64	596273c8f52d	Peifeng Yu	Fix missing header description	Jul 13 2016, 9:45 PM
596273c8f52d	689f8992eda1	621372839bdd	Peifeng Yu	LLDB plugin unit tests: fix testInsertAndRemoveBreakpointWhileRunning, add… (Show More…)	Jul 11 2016, 4:09 PM
621372839bdd	4fcac23eee30	17b7b0dc263c 72388379a95b	Peifeng Yu	Merge branch 'master' into peifeng/lldb-plugin	Jul 11 2016, 3:52 PM
17b7b0dc263c	a841ce76d237	d55fce969361	Peifeng Yu	Finish adding mostly all unit tests from gdb to lldb	Jul 11 2016, 4:59 AM
d55fce969361	72f2e66409d1	5a3f3dda0783	Peifeng Yu	Add unit tests about stack/variables for lldb plugin	Jul 10 2016, 8:09 PM
5a3f3dda0783	054d54972e67	bb9e7f813f00	Peifeng Yu	Associate MIVariable to MIDebugSession	Jul 10 2016, 7:46 PM
bb9e7f813f00	d6133aaa2e5f	3ade893e109d	Peifeng Yu	More unit tests on variable watches for lldb plugin	Jul 10 2016, 5:56 PM
3ade893e109d	e04f90625fbf	89e664761446	Peifeng Yu	Fix lldb unit test COMPARE won't stop test if failed. (Show More…)	Jul 10 2016, 5:14 PM
89e664761446	ca222f54980b	0db0a0ba9430	Peifeng Yu	Fix LldbVariable doesn't handle empty changelist	Jul 10 2016, 4:55 PM
0db0a0ba9430	0a58ca59675f	863be428729e	Peifeng Yu	Add and fix unit tests for update local variable for lldb plugin	Jul 10 2016, 5:42 AM
863be428729e	4a19e4c8ef7b	ba0cbbb9e856	Peifeng Yu	Add unit tests for examine core for lldb plugin	Jul 9 2016, 11:57 PM
ba0cbbb9e856	cf2ef6fd7fd5	9d0d9ac25dc1	Peifeng Yu	Add and fix attaching related unit tests for lldb plugin (Show More…)	Jul 9 2016, 11:41 PM
9d0d9ac25dc1	6dafe2451fc6	dcc0416552ba	Peifeng Yu	Add and fix stack related unit tests for lldb plugin	Jul 9 2016, 11:00 PM
dcc0416552ba	077ef00f797f	4d7e8a20e8b7	Peifeng Yu	Add breakpoint related unit test for lldb plugin	Jun 22 2016, 1:16 AM
4d7e8a20e8b7	f953193cf236	e27a2b9170c9	Peifeng Yu	lldb runs in async mode, no need to interrupt	Jun 22 2016, 1:14 AM
e27a2b9170c9	0e737f413db4	c48e2fd16dcc	Peifeng Yu	Fix mixing -f and other flags in -break-insert in lldb-mi	Jun 21 2016, 9:06 PM
c48e2fd16dcc	f201d927abc9	442e03f591ce	Peifeng Yu	Added and fixed lldb stdout test	Jun 19 2016, 7:22 AM
442e03f591ce	73f54187c3ce	10314822f773	Peifeng Yu	Fix lldbdebugger version check	Jun 19 2016, 7:19 AM
10314822f773	ecd18ed90fcd	1615e3ed0632	Peifeng Yu	Fix stderr/stdout from inferior is connect to stdout/stderr in MIDebugJob	Jun 19 2016, 6:21 AM
1615e3ed0632	125baa9b7267	88c05dc5188b	Peifeng Yu	No need to stop debugger if it's not started. (It's possible that the debugger… (Show More…)	Jun 19 2016, 6:14 AM
88c05dc5188b	590d5eef6c1a	e517dac77c87	Peifeng Yu	Unit tests for lldb plugin works now. more tests coming	Jun 22 2016, 6:57 PM
e517dac77c87	9c3c35716e85	fbfc11861bd8	Peifeng Yu	Basic LLDB DebugSession implementation	Jun 9 2016, 12:26 AM
fbfc11861bd8	5a64a8675b14	3eb2835c5b2a	Peifeng Yu	SignalHandle command now works with lldb	Jun 8 2016, 8:18 PM
3eb2835c5b2a	980f3f086d6c	30f9ac4dc38c	Peifeng Yu	Initial step to LLDB debugger support (Show More…)	Jun 6 2016, 4:21 AM

Merge LLDB plugin into masterClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 5554

debuggers/CMakeLists.txt

debuggers/common/CMakeLists.txt

debuggers/common/dbgglobal.h

debuggers/common/mi/micommand.cpp

debuggers/common/mi/miparser.cpp

debuggers/common/midebugger.cpp

debuggers/common/midebuggerplugin.h

debuggers/common/midebuggerplugin.cpp

debuggers/common/midebugjobs.cpp

debuggers/common/midebugsession.h

debuggers/common/midebugsession.cpp

debuggers/common/miframestackmodel.cpp

debuggers/common/mivariable.h

debuggers/common/mivariable.cpp

debuggers/common/mivariablecontroller.h

debuggers/common/mivariablecontroller.cpp

debuggers/common/widgets/debuggerconsoleview.h

debuggers/common/widgets/debuggerconsoleview.cpp

debuggers/common/widgets/debuggerconsoleview.ui

debuggers/common/widgets/disassemblewidget.h

debuggers/common/widgets/disassemblewidget.cpp

debuggers/gdb/CMakeLists.txt

debuggers/gdb/debuggerplugin.h

debuggers/gdb/debuggerplugin.cpp

debuggers/gdb/debugsession.h

debuggers/gdb/debugsession.cpp

debuggers/gdb/gdb.cpp

debuggers/gdb/gdbconfigpage.cpp

debuggers/gdb/unittests/CMakeLists.txt

debuggers/gdb/unittests/debugeeechoenv.cpp

debuggers/gdb/unittests/test_gdb.h

debuggers/gdb/unittests/test_gdb.cpp

debuggers/lldb/CMakeLists.txt

debuggers/lldb/Messages.sh

debuggers/lldb/TODO.txt

debuggers/lldb/controllers/breakpointcontroller.h

debuggers/lldb/controllers/breakpointcontroller.cpp

debuggers/lldb/controllers/framestackmodel.h

debuggers/lldb/controllers/framestackmodel.cpp

debuggers/lldb/controllers/variable.h

debuggers/lldb/controllers/variable.cpp

debuggers/lldb/controllers/variablecontroller.h

debuggers/lldb/controllers/variablecontroller.cpp

debuggers/lldb/debuggerplugin.h

debuggers/lldb/debuggerplugin.cpp

debuggers/lldb/debugsession.h

debuggers/lldb/debugsession.cpp

debuggers/lldb/kdevlldb.json

debuggers/lldb/kdevlldb.qrc

debuggers/lldb/kdevlldbui.rc

debuggers/lldb/lldbcommand.h

debuggers/lldb/lldbcommand.cpp

debuggers/lldb/lldbdebugger.h

debuggers/lldb/lldbdebugger.cpp

debuggers/lldb/lldblauncher.h

debuggers/lldb/lldblauncher.cpp

debuggers/lldb/unittests/debugees/CMakeLists.txt

debuggers/lldb/unittests/debugees/debugee space.cpp

debuggers/lldb/unittests/debugees/debugee.cpp

debuggers/lldb/unittests/debugees/debugeecrash.cpp

debuggers/lldb/unittests/debugees/debugeeechoenv.cpp

debuggers/lldb/unittests/debugees/debugeeexception.cpp

debuggers/lldb/unittests/debugees/debugeemultilocbreakpoint.cpp

debuggers/lldb/unittests/debugees/debugeemultiplebreakpoint.cpp

debuggers/lldb/unittests/debugees/debugeeqt.cpp

debuggers/lldb/unittests/debugees/debugeerecursion.cpp

debuggers/lldb/unittests/debugees/debugeeslow.cpp

debuggers/lldb/unittests/debugees/debugeethreads.cpp

debuggers/lldb/unittests/debugees/path with space/CMakeLists.txt

debuggers/lldb/unittests/debugees/path with space/spacedebugee.cpp

debuggers/lldb/unittests/test_lldb.h

debuggers/lldb/unittests/test_lldb.cpp

debuggers/lldb/unittests/testhelper.h

debuggers/lldb/unittests/testhelper.cpp

debuggers/lldb/widgets/lldbconfigpage.h

Merge LLDB plugin into master
ClosedPublic
Actions

Revision Contents
Changeset List