Differential D2292

Reapply some patches to 5.0 that are lost when merging into master
ClosedPublic
Actions

Authored by qi437103 on Jul 26 2016, 7:01 PM.

Details

Reviewers
kfunk
Commits
R32:0f623d54c4db: Reapply some patches to 5.0 that are lost when merging into master
Test Plan

it compiles, and passes all gdb unit tests on my box.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
qi437103 updated this revision to Diff 5508.Jul 26 2016, 7:01 PM
qi437103 retitled this revision from to Reapply some patches to 5.0 that are lost when merging into master.
qi437103 updated this object.
qi437103 edited the test plan for this revision. (Show Details)
qi437103 added a reviewer: kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 26 2016, 7:01 PM
kfunk accepted this revision.Jul 26 2016, 7:19 PM
kfunk edited edge metadata.
kfunk added inline comments.
debuggers/gdb/debugsession.h
78

// -> /// to make it proper doxygen-style comments

Would just remove the first two lines...

98

Could initialize with = false directly

This revision is now accepted and ready to land.Jul 26 2016, 7:19 PM
Closed by commit R32:0f623d54c4db: Reapply some patches to 5.0 that are lost when merging into master (authored by qi437103). · Explain WhyJul 26 2016, 7:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5509

View Options

debuggers/common/miframestackmodel.cpp

Loading...
View Options

debuggers/gdb/debugsession.h

Loading...
View Options

debuggers/gdb/debugsession.cpp

Loading...
View Options

debuggers/gdb/gdb.h

Loading...
View Options

debuggers/gdb/gdbframestackmodel.cpp

Loading...
View Options

debuggers/gdb/unittests/test_gdb.cpp

Loading...