Differential D2290

Ignore delta 0 wheel events on OSX
ClosedPublic
Actions

Authored by michaelchapman on Jul 26 2016, 1:06 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Commits
R37:16b7db53755a: Ignore delta 0 wheel events on OSX
Summary

A bug in OSX causes delta 0 mouse wheel events to trigger when
a pen approaches a wacom tablet, causing krita to zoom out, so
ignore delta 0 wheel events on OSX.

https://bugs.kde.org/show_bug.cgi?id=364173

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
michaelchapman updated this revision to Diff 5504.Jul 26 2016, 1:06 PM
michaelchapman retitled this revision from to Ignore delta 0 wheel events on OSX.
michaelchapman updated this object.
michaelchapman edited the test plan for this revision. (Show Details)
michaelchapman set the repository for this revision to R37 Krita.
michaelchapman added a comment.Jul 26 2016, 1:14 PM

I've tested this locally on OSX 10.11.6 with a Wacom Cintiq 12HD and it seems to remove the spurious wheel events while zoom in and out with the mouse wheel still functions as expected, but I don't know if it adversely affects any other component or behaviour.

rempt added a subscriber: rempt.Jul 28 2016, 11:12 AM
Closed by commit R37:16b7db53755a: Ignore delta 0 wheel events on OSX (authored by rempt). · Explain WhyJul 28 2016, 11:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibs/ui/input/kis_input_manager.cpp (11 lines)

Diff 5535

View Options

libs/ui/input/kis_input_manager.cpp

Loading...