Added Automatic Tests For Two Way Anova.
Diff Detail
- Repository
- R262 LabPlot
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/backend/hypothesisTest/HypothesisTest.cpp | ||
---|---|---|
304 | I would suggest to use sqrt() from cmath instead of qSqrt(). What do you think? | |
747 | you are doing a lot of basic statistical calculations. Can you check if any GSL function can be used (see https://www.gnu.org/software/gsl/doc/html/statistics.html)? | |
843 | translation? | |
849 | translation? | |
1375 | check indentation |
src/backend/hypothesisTest/HypothesisTest.cpp | ||
---|---|---|
304 | Yes you are right. | |
747 | The reason that I am doing so many basic calculations is to increase performance. If I will use functions then I have to call separate functions for mean, std deviation and other statistical calculations. Though asymptotically it will also end up in O(n) but for practical purposes, it will turn out to be slower as here I am transversing through the whole data only twice and there it will be f times (where f >= number of statistical calculations) | |
843 | the translation is automatic in getHtmlTable3 function | |
849 | It is there in getHtmlTable3 method. | |
1375 | It is indented in the source file. I don't know why it is not shown in the differnce file. |
src/backend/hypothesisTest/HypothesisTest.cpp | ||
---|---|---|
747 | I'm not sure if i understand your argument. You don't have to calculate it f times when you save the values. Also the performance should not be a problem. I would really recommend to use GSL function to improve readability and maintainability. Of course only if it fits to the workflow. Just think about it. | |
843 | ok | |
849 | ok | |
1375 | ok. This seems to happen sometimes. |
src/backend/hypothesisTest/HypothesisTest.cpp | ||
---|---|---|
747 | Yes, you are right. it will improve readability and maintainability. Will use gsl functions. |