Don't update the column automatically to an unique name when changing the column name. Now the Lineedit is red if the name is already in use and the name is not replaced.
Details
Details
Diff Detail
Diff Detail
- Repository
- R262 LabPlot
- Lint
Lint Skipped - Unit
Unit Tests Skipped
| src/backend/core/AspectTreeModel.cpp | ||
|---|---|---|
| 393 ↗ | (On Diff #61088) | Can it be like this i18n("The name \"%1\" is already in use. Choose another name.", value.toString()) to avoid word puzzles? Thanks. |
| src/backend/core/AbstractAspect.cpp | ||
|---|---|---|
| 224–225 ↗ | (On Diff #60880) | no brackets for one-liners. |
| src/backend/core/AbstractAspect.h | ||
| 266 | bool as the return type. | |
| src/backend/core/AspectTreeModel.h | ||
| 97 ↗ | (On Diff #61104) | we have a similar signal already in AbstractAspect::statusInfo(). Let's call it here similarly. |
| src/kdefrontend/dockwidgets/BaseDock.cpp | ||
| 3 ↗ | (On Diff #61104) | check the indentation here. |
| src/kdefrontend/dockwidgets/BaseDock.h | ||
| 6 ↗ | (On Diff #61104) | 2019 only. |
| 45 ↗ | (On Diff #61104) | m_leName |
| 46 ↗ | (On Diff #61104) | m_leComment |
Comment Actions
LabelWidget doesn't need to inherit from BaseDock. I'll push your patch without the changes on LabelWidget.