Updated screenshots from payee views for 5.0.5 due to the change in a tab's name from "Default Account" to "Default Category"
Details
Details
Diff Detail
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I didn't realize this while taking the screenshots but the text in the section dividers changed from black to white (also the tan is a slightly different shade). I'm on the default breeze and haven't modified any of KMM's color settings. Are the different font colors an issue?
Comment Actions
Looks good to me (certainly better than I would have gotten.) I have no idea why that text color would have changed. I'll give others a chance to suggest why it happened, but unless fixing it is trivially easy, I'll accept as is.
Thanks for the work.
Comment Actions
I am not sure, but we had a change some time back for better contrast in that area. The font size seems to be a bit smaller, but I think that is complaining on a very high level. So it's fine with me.
Comment Actions
Thomas - can you tell me how to land this making Joshua the author, or can you make the commit? Thanks.
Comment Actions
I think if you use arc land it will make you the author and the original author is only mentioned here. If I remeber it right, I used something like the following the last time:
git checkout 5.0 git pull -r git branch -D arcpatch-D22152
The above makes sure, you have a somewhat clean environment. The following adds the patch and moves it to the top of the local 5.0 branch.
arc patch D22152 git rebase 5.0
Now we make this the new 5.0 HEAD
git checkout 5.0 git rebase arcpatch-D22152
and cleanup the branch locally and push to the global repo
git branch -d arcpatch-D22152 git push origin 5.0
Keeping the last line of the commit message untouched takes care of closing the revision during git push
Comment Actions
These screenshots used Liberation Sans 9pt as recommended here: https://userbase.kde.org/Taking_Screenshots
I might not have done that the last time I took these screenshots as my system was set to Noto Sans 10pt before I took these screenshots. I have no problem retaking them with a larger font if you would like.