Make valid filter for all files

Authored by pwojcik on Jun 18 2019, 6:14 PM.



Fix filter so files can be actually listed and opened from file dialog. On occasion, make filter translatable.

I couldn't find po/ts files to update, however.

Test Plan

Run kdiff3, click "File…" button, try to select any file in dialog.

Diff Detail

R983 KDiff3
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
pwojcik requested review of this revision.Jun 18 2019, 6:14 PM
pwojcik created this revision.
mreeves requested changes to this revision.Jun 18 2019, 10:43 PM
This comment was removed by mreeves.
This revision now requires changes to proceed.Jun 18 2019, 10:43 PM

I'll have closer look on Friday to make this works as expected.

As you removed your first comment, I assume you do not need asked informations to find issue. I'll be around in case I could help by providing info or any other way.

mreeves accepted this revision.Jun 21 2019, 7:24 PM

Go ahead and land this. This is more inline with other examples online.

This revision is now accepted and ready to land.Jun 21 2019, 7:24 PM

Thanks for acceptation. Unfortunately, I have no permissions to push code. Could you do that for me?

This revision was automatically updated to reflect the committed changes.