Differential D21885

Make valid filter for all files
ClosedPublic
Actions

Authored by pwojcik on Jun 18 2019, 6:14 PM.

Details

Reviewers
mreeves
Commits
R983:fa6d0d8a0505: Make valid filter for all files
Summary

Fix filter so files can be actually listed and opened from file dialog. On occasion, make filter translatable.

I couldn't find po/ts files to update, however.

Test Plan

Run kdiff3, click "File…" button, try to select any file in dialog.

Diff Detail

Repository
R983 KDiff3
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pwojcik requested review of this revision.Jun 18 2019, 6:14 PM
pwojcik created this revision.
mreeves requested changes to this revision.Jun 18 2019, 10:43 PM
This comment was removed by mreeves.
This revision now requires changes to proceed.Jun 18 2019, 10:43 PM
mreeves added a comment.Jun 18 2019, 10:59 PM

I'll have closer look on Friday to make this works as expected.

pwojcik added a comment.Jun 19 2019, 3:22 PM

As you removed your first comment, I assume you do not need asked informations to find issue. I'll be around in case I could help by providing info or any other way.

mreeves accepted this revision.Jun 21 2019, 7:24 PM

Go ahead and land this. This is more inline with other examples online.

This revision is now accepted and ready to land.Jun 21 2019, 7:24 PM
pwojcik added a comment.Jun 22 2019, 6:35 AM

Thanks for acceptation. Unfortunately, I have no permissions to push code. Could you do that for me?

Closed by commit R983:fa6d0d8a0505: Make valid filter for all files (authored by pwojcik, committed by mreeves). · Explain WhyJun 30 2019, 2:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/smalldialogs.cpp (4 lines)

Diff 60848

View Options

src/smalldialogs.cpp

Loading...