Display only icons in column "Translation Status"
ClosedPublic

Authored by aspotashev on Jun 13 2019, 12:47 AM.

Details

Summary

catalogmodel: Convert enum CatalogModelColumns to enum class

catalogmodel: Factorize calculation of translation status into CatalogTreeModel::getTranslationStatus()

catalogmodel: Display only icons in column "Translation Status"

This lets the user save some screen space by shrinking this column.

catalogmodel: Fix compiler warnings about incomplete switch operator

screenshot:

Test Plan

Manually tested:

  1. contents of column "Translation Status" with Russian digikam.po where we have all 3 statuses;
  2. new tooltips;
  3. sorting by column "Translation Status".

Diff Detail

Repository
R456 Lokalize
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aspotashev requested review of this revision.Jun 13 2019, 12:47 AM
aspotashev created this revision.
aspotashev edited the summary of this revision. (Show Details)Jun 13 2019, 12:50 AM

Thanks a lot Alexander,
That's a great idea, I will test that and https://phabricator.kde.org/D21753 this week-end

sdepiets accepted this revision.Jun 16 2019, 4:21 AM

Great thanks

This revision is now accepted and ready to land.Jun 16 2019, 4:21 AM
This revision was automatically updated to reflect the committed changes.