Differential D2132

Associate MIVariable with MIDebugSession
ClosedPublic
Actions

Authored by qi437103 on Jul 10 2016, 7:41 PM.

Details

Reviewers

apol

Group Reviewers

KDevelop

Commits

R32:72388379a95b: Associate MIVariable with MIDebugSession

Summary

Resolving a FIXME in MIVariable, make MIVariable use per session map.
This also helps lldb plugin, which has to enumerate the map to update variables,
otherwise it would also update variables for other sessions.

Test Plan

gdb unit tests and lldb unit tests (on peifeng/lldb-plugin branch)

Diff Detail

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

qi437103 updated this revision to Diff 5069.Jul 10 2016, 7:41 PM

qi437103 retitled this revision from to Associate MIVariable with MIDebugSession.

qi437103 updated this object.

qi437103 edited the test plan for this revision. (Show Details)

qi437103 added a reviewer: apol.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 10 2016, 7:41 PM

qi437103 added a reviewer: KDevelop.Jul 10 2016, 7:41 PM

apol accepted this revision.Jul 11 2016, 11:02 AM

apol edited edge metadata.

This revision is now accepted and ready to land.Jul 11 2016, 11:02 AM

Closed by commit R32:72388379a95b: Associate MIVariable with MIDebugSession (authored by qi437103). · Explain WhyJul 11 2016, 3:42 PM

This revision was automatically updated to reflect the committed changes.

Other than that, LGTM

debuggers/common/midebugsession.cpp
123	Method should be const
127	To make sure the map isn't modified (although it won't being const) use `m_allvariiables->value(varobjname)`.

Done.

Since I have already landed this, do I just push the change to master?

Go for it.

Revision Contents
Changeset List

			Path	Packages
M			debuggers/common/midebugsession.h (10 lines)
M			debuggers/common/midebugsession.cpp (22 lines)
M			debuggers/common/mivariable.h (19 lines)
M			debuggers/common/mivariable.cpp (110 lines)
M			debuggers/common/mivariablecontroller.cpp (6 lines)
M			debuggers/gdb/gdbvariable.h (4 lines)
M			debuggers/gdb/gdbvariable.cpp (6 lines)
M			debuggers/gdb/unittests/test_gdb.cpp (14 lines)