Differential D21019

Move preference out of type for Email
ClosedPublic
Actions

Authored by vkrause on May 4 2019, 5:48 PM.

Details

Reviewers
mlaurent
Commits
R174:7e7aa2abcef2: Move preference out of type for Email
Summary

Preference being a type flag is vCard 3.0 style, preference being a
separate parameter is vCard 4.0 style.

This does not change how we actually serialize this, just make the API
consistent with e.g. ResourceLocatorUrl and Impp.

Diff Detail

Repository
R174 KContacts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.May 4 2019, 5:48 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 4 2019, 5:48 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.May 4 2019, 5:48 PM
mlaurent accepted this revision.May 6 2019, 2:45 PM
mlaurent added a subscriber: mlaurent.

For me seems good :)
(sorry for the delay, no internet during 4 days + holidays :))

This revision is now accepted and ready to land.May 6 2019, 2:45 PM
Closed by commit R174:7e7aa2abcef2: Move preference out of type for Email (authored by vkrause). · Explain WhyMay 6 2019, 4:21 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 57658