Replace importFile LineEdit with KUrlComboBox to save the paths to the last imported files
ClosedPublic

Authored by Murmele on May 4 2019, 12:08 PM.

Diff Detail

Repository
R262 LabPlot
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Murmele created this revision.May 4 2019, 12:08 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 4 2019, 12:08 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
Murmele requested review of this revision.May 4 2019, 12:08 PM
Murmele updated this revision to Diff 57547.May 4 2019, 12:50 PM
asemke added inline comments.May 4 2019, 3:47 PM
src/kdefrontend/datasources/ImportFileWidget.cpp
175

no brackets for one-liners

1213

we don't really need this temp variable. Let's do it directly with QString fileName = absolutePath(fileName());

src/kdefrontend/datasources/ImportFileWidget.h
108

let's add default initialization here - KUrlComboBox* m_cbFileName{nullptr};

128

const QUrl&

Murmele updated this revision to Diff 57552.May 4 2019, 4:09 PM
Murmele updated this revision to Diff 57558.May 4 2019, 4:37 PM
Murmele updated this revision to Diff 57559.May 4 2019, 4:43 PM
asemke accepted this revision.May 4 2019, 5:46 PM
This revision is now accepted and ready to land.May 4 2019, 5:46 PM
This revision was automatically updated to reflect the committed changes.