Differential D20538

Remove KContact::Geo QObject wrapper for Grantlee
ClosedPublic
Actions

Authored by vkrause on Apr 14 2019, 2:35 PM.

Details

Reviewers

Commits

R82:20fa89707856: Remove KContact::Geo QObject wrapper for Grantlee

Summary

No longer needed, as KContact types can now be consumed directly for this.
There's minor behavior differences (e.g. regarding return values for
invalid coordinates), but since no template seems to be using this that
shouldn't be a problem.

Diff Detail

Repository

R82 KDE PIM Application Libraries

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Apr 14 2019, 2:35 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 14 2019, 2:35 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

vkrause requested review of this revision.Apr 14 2019, 2:35 PM

Harbormaster completed remote builds in B10843: Diff 56205.Apr 14 2019, 2:35 PM

Add missing pieces of the patch.

Harbormaster completed remote builds in B10845: Diff 56207.Apr 14 2019, 3:06 PM

mlaurent accepted this revision.Apr 14 2019, 5:49 PM

This revision is now accepted and ready to land.Apr 14 2019, 5:49 PM

Closed by commit R82:20fa89707856: Remove KContact::Geo QObject wrapper for Grantlee (authored by vkrause). · Explain WhyApr 16 2019, 6:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (2 lines)
M		kaddressbookgrantlee/src/CMakeLists.txt (1 line)
D	M	kaddressbookgrantlee/src/contactobject/contactgrantleegeoobject.h (48 lines)
D	M	kaddressbookgrantlee/src/contactobject/contactgrantleegeoobject.cpp (62 lines)
M		kaddressbookgrantlee/src/formatter/grantleecontactformatter.cpp (1 line)
M		kaddressbookgrantlee/src/printing/contactgrantleeprintobject.h (2 lines)
M		kaddressbookgrantlee/src/printing/contactgrantleeprintobject.cpp (5 lines)
M		kaddressbookgrantlee/src/printing/grantleeprint.h (3 lines)
M		kaddressbookgrantlee/src/printing/grantleeprint.cpp (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56205	0444d43		Apr 14 2019, 2:35 PM	★	★
Diff 2	56207	0444d43	Add missing pieces of the patch.	Apr 14 2019, 3:06 PM	★	★
Diff 3	56390	4508a21	R82:20fa897078569deb0329aff8e41702467ce40ea3	Apr 16 2019, 6:06 PM	★	★