Differential D20480

Add support for a few non-standard extensions we commonly use
ClosedPublic
Actions

Authored by vkrause on Apr 12 2019, 7:20 AM.

Details

Reviewers
mlaurent
Commits
R174:0a2ef596f09c: Add support for a few non-standard extensions we commonly use
Summary

String-based access to those fields is spread over several modules, which
is error prone and hard to maintain. Better centralize this here, even if
it's not strictly part of the vCard standard.

Diff Detail

Repository
R174 KContacts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 12 2019, 7:20 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 12 2019, 7:20 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 12 2019, 7:20 AM
mlaurent added a subscriber: mlaurent.Apr 12 2019, 7:28 AM

Please increase kcontact version so we can use it in other module.
Otherwise it seems ok

vkrause updated this revision to Diff 56044.Apr 12 2019, 9:14 AM

Add blog feed field which I had missed previously (yes, this does not use the "X" prefix).

The version bump is in the still pending commit adding Q_PROPERTYs, give me a bit to finish that.

mlaurent accepted this revision.Apr 12 2019, 9:54 AM

Ok no problem for increase version after Q_PROPERTYs commit.

This revision is now accepted and ready to land.Apr 12 2019, 9:54 AM
Closed by commit R174:0a2ef596f09c: Add support for a few non-standard extensions we commonly use (authored by vkrause). · Explain WhyApr 16 2019, 5:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/addressee.h (91 lines)
Msrc/addressee.cpp (108 lines)

Diff 56378

View Options

src/addressee.h

Loading...
View Options

src/addressee.cpp

Loading...