Normalize country names more aggressively for ISO code lookup
ClosedPublic

Authored by vkrause on Apr 12 2019, 6:34 AM.

Details

Summary

Without increasing the number of ambiguities this makes the country
detection a bit more robust and shrinks the database by about 50kB/10%.

While stripping non-letters and diacritic marks in Latin is fairly
straightforward and predictable, the results were less helpful in e.g.
Hangul, therefore the fairly fine-grained approach.

This requires the country name lookup table to be regenerated, which is
omitted in this review for clarity (it's a 95k line diff).

Diff Detail

Repository
R174 KContacts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 12 2019, 6:34 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 12 2019, 6:34 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 12 2019, 6:34 AM
mlaurent accepted this revision.Apr 12 2019, 6:37 AM
mlaurent added a subscriber: mlaurent.

seems ok for me

This revision is now accepted and ready to land.Apr 12 2019, 6:37 AM
This revision was automatically updated to reflect the committed changes.