Differential D19282

Fix formatting, spaces before '(', conformity with the current interface
ClosedPublic
Actions

Authored by yurchor on Feb 24 2019, 5:24 PM.

Details

Reviewers

Group Reviewers

Krita
Krita: Manual

Commits

R1012:1136b000beb1: Fix formatting, spaces before '(', conformity with the current interface

Summary

Minor formatting and content fixes

Test Plan

none

Diff Detail

Repository

R1012 Krita.org Documentation Website

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

yurchor created this revision.Feb 24 2019, 5:24 PM

Restricted Application added a project: Krita: Manual. · View Herald TranscriptFeb 24 2019, 5:24 PM

Restricted Application added a reviewer: Krita: Manual. · View Herald Transcript

yurchor requested review of this revision.Feb 24 2019, 5:24 PM

Harbormaster completed remote builds in B8781: Diff 52463.Feb 24 2019, 5:24 PM

Ok, so it looks good, but the thing is that restructured text requires title underlines to be equal or bigger than the text they underline. Given that this error shows up multiple times here, can I tempt you to fix it and resubmit the patch?

reference_manual/blending_modes/lighten.rst
177–178	Restructured text requires the underline to be equal or bigger than the title. So this gives an error.
reference_manual/brushes/brush_engines/dyna_brush_engine.rst
35–36	Underline too short here too.
reference_manual/filters/emboss.rst
29–30	underline too short.
user_manual/loading_saving_brushes.rst
470–471	underline too short.

This revision now requires changes to proceed.Feb 24 2019, 5:30 PM

Fix headings

Harbormaster completed remote builds in B8784: Diff 52467.Feb 24 2019, 5:34 PM

Sure. Thanks for your review.

Ok, will push.

This revision is now accepted and ready to land.Feb 24 2019, 5:46 PM

Closed by commit R1012:1136b000beb1: Fix formatting, spaces before '(', conformity with the current interface (authored by yurchor, committed by woltherav). · Explain WhyFeb 24 2019, 5:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			contributors_manual/krita_manual_conventions.rst (2 lines)
M			contributors_manual/krita_manual_readme.rst (6 lines)
M			general_concepts/colors/bit_depth.rst (12 lines)
M			general_concepts/colors/color_managed_workflow.rst (22 lines)
M			general_concepts/colors/color_mixing.rst (4 lines)
M			general_concepts/colors/color_models.rst (6 lines)
M			general_concepts/colors/color_space_size.rst (4 lines)
M			general_concepts/colors/linear_and_gamma.rst (2 lines)
M			general_concepts/colors/profiling_and_callibration.rst (2 lines)
M			general_concepts/colors/scene_linear_painting.rst (14 lines)
M			general_concepts/colors/viewing_conditions.rst (4 lines)
M			general_concepts/file_formats/file_exr.rst (2 lines)
M			general_concepts/file_formats/file_gif.rst (2 lines)
M			general_concepts/file_formats/file_gih.rst (2 lines)
M			general_concepts/file_formats/file_jpeg.rst (2 lines)
M			general_concepts/file_formats/file_ora.rst (2 lines)
M			general_concepts/file_formats/file_pbgpm.rst (2 lines)
M			general_concepts/file_formats/file_psd.rst (2 lines)
M			general_concepts/file_formats/file_svg.rst (2 lines)
M			general_concepts/file_formats/lossy_lossless.rst (4 lines)
M			general_concepts/projection/axonometric.rst (8 lines)
M			general_concepts/projection/orthographic_oblique.rst (4 lines)
M			general_concepts/projection/perspective.rst (2 lines)
M			reference_manual/blending_modes.rst (2 lines)
M			reference_manual/blending_modes/hsx.rst (10 lines)
M			reference_manual/blending_modes/lighten.rst (4 lines)
M			reference_manual/brushes/brush_engines/clone_engine.rst (4 lines)
M			reference_manual/brushes/brush_engines/color_smudge_engine.rst (2 lines)
M			reference_manual/brushes/brush_engines/dyna_brush_engine.rst (4 lines)
M			reference_manual/brushes/brush_engines/spray_brush_engine.rst (2 lines)
M			reference_manual/brushes/brush_engines/tangen_normal_brush_engine.rst (8 lines)
M			reference_manual/brushes/brush_settings/brush_tips.rst (2 lines)
M			reference_manual/brushes/brush_settings/options.rst (2 lines)
M			reference_manual/brushes/brush_settings/texture.rst (4 lines)
M			reference_manual/dockers/advanced_color_selector.rst (4 lines)
M			reference_manual/dockers/grids_and_guides.rst (2 lines)
M			reference_manual/dockers/layers.rst (8 lines)
M			reference_manual/dockers/lut_management.rst (2 lines)
M			reference_manual/dockers/onion_skin.rst (4 lines)
M			reference_manual/dockers/palette_docker.rst (8 lines)
M			reference_manual/dockers/timeline.rst (18 lines)
M			reference_manual/filters/adjust.rst (8 lines)
M			reference_manual/filters/artistic.rst (2 lines)
M			reference_manual/filters/colors.rst (2 lines)
M			reference_manual/filters/edge_detection.rst (2 lines)
M			reference_manual/filters/emboss.rst (4 lines)
M			reference_manual/filters/map.rst (2 lines)
M			reference_manual/instant_preview.rst (6 lines)
M			reference_manual/layers_and_masks/file_layers.rst (2 lines)
M			reference_manual/layers_and_masks/selection_masks.rst (2 lines)
M			reference_manual/main_menu/edit_menu.rst (6 lines)
M			reference_manual/main_menu/layers_menu.rst (16 lines)
M			reference_manual/preferences/performance_settings.rst (14 lines)
M			reference_manual/render_animation.rst (2 lines)
M			reference_manual/resource_management.rst (2 lines)
M			reference_manual/resource_management/resource_gradients.rst (2 lines)
M			reference_manual/resource_management/resource_workspace.rst (4 lines)
M			reference_manual/tools/colorize_mask.rst (8 lines)
M			reference_manual/tools/freehand_brush.rst (2 lines)
M			reference_manual/tools/move.rst (4 lines)
M			reference_manual/tools/multibrush.rst (2 lines)
M			reference_manual/tools/path.rst (2 lines)
M			reference_manual/tools/pattern_edit.rst (2 lines)
M			reference_manual/tools/polygon.rst (2 lines)
M			reference_manual/tools/shape_edit.rst (4 lines)
M			reference_manual/tools/shape_selection.rst (2 lines)
M			reference_manual/tools/text.rst (4 lines)
M			reference_manual/tools/zoom.rst (8 lines)
M			tutorials/common_workflows.rst (2 lines)
M			tutorials/flat-coloring.rst (14 lines)
M			tutorials/inking.rst (6 lines)
M			tutorials/krita-brush-tips/animated_brushes.rst (4 lines)
M			tutorials/krita-brush-tips/fur.rst (2 lines)
M			tutorials/krita-brush-tips/outline.rst (2 lines)
M			tutorials/krita-brush-tips/sculpt-paint-brush.rst (2 lines)
M			user_manual/animation.rst (8 lines)
M			user_manual/getting_started/basic_concepts.rst (22 lines)
M			user_manual/getting_started/installation.rst (20 lines)
M			user_manual/getting_started/navigation.rst (4 lines)
M			user_manual/getting_started/starting_krita.rst (2 lines)
M			user_manual/introduction_from_other_software/introduction_from_photoshop.rst (10 lines)
M			user_manual/introduction_from_other_software/introduction_from_sai.rst (20 lines)
M			user_manual/loading_saving_brushes.rst (30 lines)
M			user_manual/painting_with_assistants.rst (4 lines)
M			user_manual/snapping.rst (2 lines)
M			user_manual/soft_proofing.rst (6 lines)
M			user_manual/vector_graphics.rst (4 lines)
M			user_manual/working_with_images.rst (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	52463	942201e		Feb 24 2019, 5:24 PM	★	★
Diff 2	52467	942201e	Fix headings	Feb 24 2019, 5:34 PM	★	★
Diff 3	52469	942201e	R1012:1136b000beb19032bb50eaf263a8f842e3e9dd22	Feb 24 2019, 5:44 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a0aa5a140a86	5d62692ced16	942201eae09c	Yuri Chornoivan	Fix formatting, spaces before '(', conformity with the current interface (Show More…)	Feb 24 2019, 5:23 PM