Update dependencies
ClosedPublic

Authored by yurchor on Feb 23 2019, 7:13 AM.

Details

Reviewers
ngraham
Group Reviewers
Spectacle
Commits
R166:b211e30e41e0: Update dependencies
Summary

Spectacle uses QProcess::startDetached() from Qt 5.10 [1] and KTitleWidget::setLevel(int) from KF 5.53 [2]. Thus it would be reasonable to update dependencies.

[1] https://doc.qt.io/qt-5/qprocess.html#startDetached
[2] https://api.kde.org/frameworks/kwidgetsaddons/html/classKTitleWidget.html#a9972cbbc2c2876ad504dc5ca5ee432d6

Test Plan

Just try to compile Spectacle git/master on some old distribution (Mageia 6). CMake does not complain, but it can be build without patching.

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Feb 23 2019, 7:13 AM
Restricted Application added a project: Spectacle. · View Herald TranscriptFeb 23 2019, 7:13 AM
yurchor requested review of this revision.Feb 23 2019, 7:13 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2019, 8:25 AM
This revision was automatically updated to reflect the committed changes.

O-o-ops... Pushed accidentally. Sorry. :'(

I will revert if inapplicable.

Nah, this looks fine!