Differential D19196

icaldir: fix build after configuration porting
ClosedPublic
Actions

Authored by nowicki on Feb 21 2019, 9:26 AM.

Details

Reviewers
mlaurent
dvratil
Commits
R44:4ca39cfec441: icaldir: fix build after configuration porting
Summary

Commit 4b71d5eaf0fe introduced a porting change of the configuration for the icaldir resource. The settingsdialog.ui file was renamed, but the reference from the CMake script remained causing a build failure.

Fix this by removing the line as it is now obsolete.

For some reason this did not trigger on CI, but it definitely fails on a clean build on my local machine.

Test Plan

Build kdepim-runtime

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nowicki created this revision.Feb 21 2019, 9:26 AM
Restricted Application added a subscriber: kde-pim. · View Herald TranscriptFeb 21 2019, 9:26 AM
nowicki requested review of this revision.Feb 21 2019, 9:26 AM
dvratil accepted this revision.Feb 21 2019, 9:40 AM

Weird, I did not notice it either and I did a clean build recently. Anyway, the file is fone so it makes sense for this to go away too. Thanks!

This revision is now accepted and ready to land.Feb 21 2019, 9:40 AM
mlaurent accepted this revision.Feb 21 2019, 5:45 PM
Closed by commit R44:4ca39cfec441: icaldir: fix build after configuration porting (authored by nowicki). · Explain WhyFeb 25 2019, 8:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mresources/icaldir/CMakeLists.txt (1 line)

Diff 52505

View Options

resources/icaldir/CMakeLists.txt

Loading...