- unit tests pass to 100%
- onlinequoteseditor seems to work
What still needs to be done is a check against KDE4 that nothing is broken.
Details
Details
Diff Detail
Diff Detail
- Repository
- R471 Alkimia Library
- Branch
- realkf5
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8526 Build 8544: arc lint + arc unit
| src/CMakeLists.txt | ||
|---|---|---|
| 75 | To my knowledge, the use of "if" inside set does not work. You can use the following instead set(alkimia_UI
alkonlinequoteswidget${ALKIMIA_PATH_SUFFIX}.ui
) | |
| src/alkonlinequote.cpp | ||
| 112 | With KDE4 moc ignores #if and includes this slot. It need to be defined also for KDE4 with an empty implementation. | |
| 347 | KDE4 QUrl does not support prettyUrl(), only KUrl - may be toString() would also be okay | |
Comment Actions
For some reason, arc played a few tricks on me and screwed up the changes. I will create a new diff based on master (well, it was probably me not paying attention on the arguments or so. I am still learning)