Details
- Reviewers
asemke - Commits
- R55:44e33d84d62b: - Rename "addUserStuff" to "addUserDefinition" - Move code for functions…
R55:e0786f6fdd6d: [Python] Add tests for variable model
R55:a02c4003f472: Fix problem with MaximaVariableModel::functionsNames()
R55:e8843ba35cbc: Add virtual method update() to DefaultVariableModel and fix small bug in…
R55:86c4b2355738: Remove outdate static_cast to DefaultVariableModel
R55:a70b4880cfee: [Octave] Add tests for variable model
R55:cd6b667e126b: Fix errors with finishExpression
R55:c108e94fe58b: [Maxima] Improve MaximaVariableModel and fix bug with unworking functions names…
R55:ddf0f444dd0f: [Octave] Add OctaveVariableModel
R55:555d70e2ec90: [R, Maxima, Octave, Python] Add option to enable/disable Variable Management.
R55:c02608c779f6: Merge branch 'master' into new-default-variable-model
R55:8d1ea3b8a9c4: Change return type for Session::variableModel to DefaultVariableModel and add…
R55:abcef0a7f816: Minor improvments
R55:c4582a8a1ea9: Some improvments in DefaultVariableModle and removing some debug output
R55:1fb13e358cf1: Add Session::finishRunExpression and move code for variable modele updating…
R55:9169aecac898: Merge fixes from master branch
R55:37db205e85ae: [R] Add tests for Variable model
R55:bab221e2b22e: [Python] Add PythonVariableModel
R55:c7e26aec6810: Merge branch 'master' into new-default-variable-model
R55:c412a5b22274: Remove MaximaVariableModel::functionsName, because this function moved into…
R55:8a55d394c485: Rename Session::forceVariableUpdate to Session::updateVariables() and minor…
R55:13ae923cede6: Connect DefaultVariableModel signals for added/removed variables/functions to…
R55:155a6ae9670b: [R] Remove outdate addUserDefinition, removeUserDefinition
R55:1f4fcdfec286: Move variables method from MaximaVariableModel to DefaultVariableModel
R55:0eabaa4f32a7: [R] Add RVariableModel
R55:fdab11ae113f: [Julia] Add Julia Variable Model and option for switching on and off the model
R55:048d28c6d848: [R, Octave] Remove some tests, which tests DefaultVariableModel functional
R55:2502a9477cdf: Huge improvments variable model in backends
R55:26d0155c66f5: Merge branch 'master' into new-default-variable-model
Diff Detail
- Repository
- R55 Cantor
- Branch
- new-default-variable-model
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9123 Build 9141: arc lint + arc unit
src/backends/R/rbackend.cpp | ||
---|---|---|
73 | Why do you want to have this as an configurable parameter? Why not to always enable and use the variable model? | |
src/backends/R/rhighlighter.h | ||
38–41 | let's move the declaration of these functions to Cantor::DefaultHighlighter and make them abstract. All deriving classes should provide an implementation for them. | |
47 | let's use "Definition" instead of "Stuff". Sounds better. | |
src/backends/R/rvariablemodel.h | ||
37 | can the signals be made part of the base class? |
src/backends/R/rsession.cpp | ||
---|---|---|
151–152 | This logic seems to be the (almost) the same for all session classes. Can we move this maybe to Session.cpp? E.g. to Session::statusChanged()? With this we don't need to touch all the session classes now and to add this m_needUpdate variable everywhere. |
Add Session::finishRunExpression and move code for variable modele updating (and expressions finishing) to Session
Tests, in this moment, fails, but i fix this soon.
src/backends/R/rsession.cpp | ||
---|---|---|
151–152 | See Session::finishFirstExpression |
src/backends/R/rhighlighter.cpp | ||
---|---|---|
84 | can the functions addUserDefinition(), removeUserDefinition(), addUserVariable(), removeUserVariable(), addUserFunction() and removeUserFunction() be moved to the base class DefaultHighlighter? | |
src/backends/R/rsession.cpp | ||
79 | why do you need to cast here? | |
134 | why do you need to cast here? | |
src/backends/julia/juliasession.h | ||
112 | m_variablModel? Why not to use the model from the base class? | |
src/backends/maxima/maximasession.cpp | ||
126 | why this cast? |
- Session::variableModel starts return DefaultVariableModel (add variableDataModel() for compatibility with KAlgebra)
- DefaultVariableModel signals for added/removed variables/functions connected to DefaultHighlighter corresponding slots
src/backends/julia/juliasession.h | ||
---|---|---|
112 | Julia don't supports our expressionQueue(). I want add the code for this before adding code for using model from base class. |
src/backends/R/rsession.cpp | ||
---|---|---|
148 ↗ | (On Diff #53016) | why do you need to cast here? |
src/backends/R/rvariablemodel.h | ||
24 ↗ | (On Diff #53016) | whitespace? |
src/backends/R/testr.cpp | ||
40 ↗ | (On Diff #53016) | whitespaces. |
48 ↗ | (On Diff #53016) | whitespaces. |
src/backends/maxima/maximavariablemodel.cpp | ||
151–152 ↗ | (On Diff #53016) | m_variableExpression seems to exist in MaximaVariableModel only. Should we define it as MaximaExpression and avoid this cast? |
src/lib/session.cpp | ||
55 ↗ | (On Diff #53016) | whitespace? |
56 ↗ | (On Diff #53016) | whitespace? |
src/lib/session.h | ||
230 ↗ | (On Diff #53016) | updateVariables() is shorter and sounds better. |
Rename Session::forceVariableUpdate to Session::updateVariables() and minor improvments
src/backends/maxima/maximavariablemodel.cpp | ||
---|---|---|
151–152 ↗ | (On Diff #53016) | I have done it. But it doesn't bring big difference, because we still need casting for Cantor::Expression from evaluateExpression to MaximaExpression. |