Add settings dialog for Cantor backends
ClosedPublic

Authored by sirgienko on Feb 16 2019, 12:52 PM.

Diff Detail

Repository
R262 LabPlot
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sirgienko created this revision.Feb 16 2019, 12:52 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 16 2019, 12:52 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
sirgienko requested review of this revision.Feb 16 2019, 12:52 PM
sirgienko updated this revision to Diff 51856.Feb 16 2019, 1:10 PM

Update menu element name

asemke added inline comments.Feb 16 2019, 4:32 PM
src/kdefrontend/MainWin.cpp
1995

Can you please labplot's code style here?

for (auto* backend : Cantor::Backend::availableBackends())
     if (backend->config()) //It has something to configure, so add it to the dialog
          cantorDialog->addPage(backend->settingsWidget(cantorDialog), backend->config(), backend->name(),  backend->icon());
sirgienko updated this revision to Diff 51878.Feb 16 2019, 4:38 PM

Update codestyle

sirgienko marked an inline comment as done.Feb 16 2019, 4:38 PM
asemke accepted this revision.Feb 16 2019, 4:39 PM
This revision is now accepted and ready to land.Feb 16 2019, 4:39 PM
yurchor added inline comments.
src/kdefrontend/MainWin.cpp
1994 ↗(On Diff #51878)

Can the "Cantor Settings" be translatable?

This revision was automatically updated to reflect the committed changes.
sirgienko added inline comments.Feb 16 2019, 4:49 PM
src/kdefrontend/MainWin.cpp
1994 ↗(On Diff #51878)

As I know, this "name" parameter don't displayed in GUI and used only inside KConfig.

yurchor added inline comments.Feb 16 2019, 5:45 PM
src/kdefrontend/MainWin.cpp
1994 ↗(On Diff #51878)

Thanks