BUG: 403880
Details
Diff Detail
- Repository
- R878 Latte Dock
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
@trmdi can you confirm me the following for your code ?
- When a layout is loaded for first time then "global shortcuts based on position" are applied based on Latte set priority for which view to be forwarded
- When the user changed the isPreferredForShortcuts for first time afterwards [1] is never used again EXCEPT if the user set the property
preferredForShortcutsTouched=false
on its own
Is this what you wanted to achieve?
Note: this is important, the preferredForShortcutsTouched property must be moved from universalsettings to layout
app/settings/universalsettings.h | ||
---|---|---|
51 ↗ | (On Diff #50814) | this needs to be part of layout.h because it should be set at per layout level if it is set at universalsettings then many things could break when the user switches layouts or uses MultipleLayouts |
My code works like this:
1, if the user has never touched the Behavior > Activate... checkbox, Latte would automatically find the best view. (Not only the first time)
Yes, this should be moved to the layout class.
2, once he touched it, latte would remember that, and follow his setting.
What do you think?
it looks and behave nice, lets see with Layout how it will look but I believe there will be no issues,
we are ok to commit if the property is moved to Layout
I've moved it to Layout, and add a small improvement to the "Behavior> Activate based on position... " checkbox's checked value.
Please test it and improve it if needed.
app/shortcuts/globalshortcuts.cpp | ||
---|---|---|
810 |
please make a check that sortedViewsList returns count()>0 and if it doesnt it can return a nullptr
|
1, please make a check that sortedViewsList returns count()>0 and if it doesnt it can return a nullptr
-> done
2, your turn
@trmdi would you like to commit it for you?
Can I use your fullname shown at: https://phabricator.kde.org/p/trmdi/ ?
and what is your email?
Yes, I don't have the commit permission.
Yes, that name, trmdi@yandex.com.
Thank you! :)