Initial version for the tool which will be used to simplify osm data at lower zoom levels
AbandonedPublic

Authored by dkolozsvari on Jun 13 2016, 9:12 PM.

Details

Reviewers
None
Group Reviewers
Marble
Summary

It is a simple tool, which for now reads an .osm map, then outputs the same .osm map without data loss.
Changes to the marble code were needed, because some bugs.

Test Plan

I tested it manually for some maps and it works fine for them, but further testing will be needed tobe surethat it doesn't leaves out any data or metadata.

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
dkolozsvari retitled this revision from to Initial version for the tool which will be used to simplify osm data at lower zoom levels.Jun 13 2016, 9:12 PM
dkolozsvari updated this object.
dkolozsvari edited the test plan for this revision. (Show Details)
dkolozsvari added a reviewer: Marble.
dkolozsvari set the repository for this revision to R34 Marble.
dkolozsvari added a subscriber: Marble.

Looks good. Can you split off the changes in src/lib and src/tools to a separate commit and push that one directly? Then we can easily backport those bugfixes.

tools/osm-simplify/CMakeLists.txt
2

Please add a license header and your name. Same in the .cpp below.

tools/osm-simplify/main.cpp
50

osm-addresses => osm-simplify

87

could also use https://doc.qt.io/qt-4.8/qfileinfo.html#suffix instead of endsWith.

93

return with an exit code != 0 here?

102

return with an exit code != 0 here?

dkolozsvari updated this revision to Diff 4420.Jun 13 2016, 9:49 PM

Reaction for Dennis' comments.

dkolozsvari updated this revision to Diff 4421.Jun 13 2016, 9:54 PM

The previous diff was wrong.

dkolozsvari marked 5 inline comments as done.Jun 13 2016, 9:56 PM
dkolozsvari abandoned this revision.Aug 23 2016, 5:03 PM