Add --imgbox and --imginputbox support for KDialog
ClosedPublic

Authored by mdminhazulhaque on Jan 1 2019, 10:39 AM.

Details

Summary

I have added 2 new options for Image Box and Image Input Box in KDialog because I did not find any.

Here is how they look.

Diff Detail

Repository
R229 KDialog
Lint
Lint Skipped
Unit
Unit Tests Skipped
mdminhazulhaque requested review of this revision.Jan 1 2019, 10:39 AM
mdminhazulhaque created this revision.
mdminhazulhaque edited the summary of this revision. (Show Details)
mdminhazulhaque edited the summary of this revision. (Show Details)
dfaure requested changes to this revision.Jan 7 2019, 9:00 AM
dfaure added a subscriber: dfaure.

Thanks for the patch, just a few adjustments needed.

src/widgets.cpp
152

It's leaked. Don't use new, create it on the stack. Well, you don't even need QImage in the first place.

label->setPixmap(QPixmap(file));
155

you already did that on line 138, you can remove this one

172

if (!text.isEmpty())

182

same as above

192

already done on line 169, remove.

This revision now requires changes to proceed.Jan 7 2019, 9:00 AM
mdminhazulhaque marked 5 inline comments as done.
dfaure accepted this revision.Jan 12 2019, 4:23 PM
This revision is now accepted and ready to land.Jan 12 2019, 4:23 PM

Can you give me your email address for the git commit?

mdminhazulhaque@gmail.com

dfaure closed this revision.Jan 12 2019, 4:36 PM