Differential D17879

Ensure StandardDirs::saveDir returns existing dir
ClosedPublic
Actions

Authored by modax on Dec 30 2018, 7:46 PM.

Details

Reviewers
dvratil
Commits
R165:28f2916db1a2: Ensure StandardDirs::saveDir returns existing dir
Summary

This is slight adapted version of the code removed in commit
278a85f8ef9a90b1707ff6f66bd1a95155f93685. I believe it got lost
unintentionally in that commit as there are lots of places in current
codebase which relies on StandardDirs::saveDir() returning existing
directory (just check comments in those places!), e.g.:

  • AkonadiServer::startDatabaseProcess()
  • PartStreamer::PartStreamer
  • StorageJanitor::verifyExternalParts()
  • etc.
Test Plan

akonadictl fsck on database with unreferenced external files actually moves
files to file_lost+found dir now.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
modax created this revision.Dec 30 2018, 7:46 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 30 2018, 7:46 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
modax requested review of this revision.Dec 30 2018, 7:46 PM
dvratil accepted this revision.Jan 4 2019, 4:41 PM
This revision is now accepted and ready to land.Jan 4 2019, 4:41 PM
Closed by commit R165:28f2916db1a2: Ensure StandardDirs::saveDir returns existing dir (authored by modax, committed by dvratil). · Explain WhyJan 4 2019, 5:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/private/standarddirs.cpp (26 lines)

Diff 48683

View Options

src/private/standarddirs.cpp

Loading...