resolve tags to the commit, that was tagged.
ClosedPublic

Authored by knauss on Dec 23 2018, 1:03 AM.

Details

Summary

until now we didn't get a list of tags, that are included in the current
commit and the list of tags was always empty.
Additionally we used the HASHID of the tag itself and not of the tagged commit.

Diff Detail

Repository
R857 CI System Tooling
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss requested review of this revision.Dec 23 2018, 1:03 AM
knauss created this revision.
bcooksley added inline comments.Dec 23 2018, 8:42 PM
helpers/check-abi.py
88

Can we use a more descriptive variable name here please?

There are other parts of the codebase which have used _ as a function.

knauss updated this revision to Diff 48104.Dec 24 2018, 2:17 AM

use better variable names.

bcooksley accepted this revision.Dec 24 2018, 5:07 PM

Thanks.

This revision is now accepted and ready to land.Dec 24 2018, 5:07 PM
This revision was automatically updated to reflect the committed changes.