Differential D17638

Enable LocaStorage in webengine
ClosedPublic
Actions

Authored by amantia on Dec 17 2018, 9:35 AM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Commits
R201:365d45a7dc1a: Enable LocaStorage in webengine
Summary

This is normally the default (but disabled in upper classes), and is needed
to play some embedded videos.
AFAIS local storage is enabled by default on all browsers.

Might fix the cookie's not remembered bug as well.

BUG: 319815
CCBUG: 379016

Diff Detail

Repository
R201 Akregator
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6105
Build 6123: arc lint + arc unit
amantia created this revision.Dec 17 2018, 9:35 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 17 2018, 9:35 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
amantia requested review of this revision.Dec 17 2018, 9:35 AM
mlaurent added a comment.Dec 17 2018, 11:08 AM

Could you split patchs please ?
I can see just one line for fixing BUG: 319815 no ?

amantia updated this revision to Diff 47715.Dec 17 2018, 11:09 AM

Remove code that was added by mistake to the review

amantia updated this revision to Diff 47716.Dec 17 2018, 11:10 AM

Remove now for real

mlaurent accepted this revision.Dec 17 2018, 1:59 PM
This revision is now accepted and ready to land.Dec 17 2018, 1:59 PM
amantia closed this revision.Dec 17 2018, 2:23 PM

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 47715