Add a progress slider to mpris remote in app
ClosedPublic

Authored by blaws on Dec 7 2018, 8:58 PM.

Details

Summary

The progress slider can be mooved to seek through the song and
will display song length and current position on sides.

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
blaws created this revision.Dec 7 2018, 8:58 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 7 2018, 8:58 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
blaws requested review of this revision.Dec 7 2018, 8:58 PM
blaws updated this revision to Diff 47073.Dec 7 2018, 9:12 PM

fix typo

nicolasfella requested changes to this revision.Dec 8 2018, 1:16 AM
nicolasfella added a subscriber: nicolasfella.

On Android the position indicator is below the other control (but above the volume control). I would prefer to do the same here.

Also the position isn't updated automatically, only when other properties changed. Have a look at how we handle the position update on the Android side

This revision now requires changes to proceed.Dec 8 2018, 1:16 AM
blaws added a comment.EditedDec 8 2018, 8:11 AM

@nicolasfella ah, okay I was copying design from plasmoid, what do you mean by position doesn't update automatically, it works fine for me?

blaws updated this revision to Diff 47111.Dec 8 2018, 1:37 PM

Update slider position with timer
Move position slider to above volume one

This revision is now accepted and ready to land.Dec 9 2018, 1:13 PM
This revision was automatically updated to reflect the committed changes.