Add support for opening or printing of multiple reports
ClosedPublic

Authored by habacker on Nov 29 2018, 7:27 AM.

Details

Summary

In the report overview select multiple reports and select one of the
available entries in the context menu opened with right mouse click.

Cherry-picked from branch 4.8, commit <to-be-filled-out>

Adjusted for KF5 by Thomas Baumgart.

BUG:401080
FIXED-IN:4.8.3, 5.0.3

Test Plan

compiled and tested on linux

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
habacker requested review of this revision.Nov 29 2018, 7:27 AM
habacker created this revision.
tbaumgart accepted this revision.Nov 29 2018, 7:37 AM

Other than that one thing it looks OK to me, well what else do we expect when the author reviews his own stuff ;-)

kmymoney/plugins/views/reports/kreportsview.cpp
615

Can you join this with the line above? Did I mess this up?

This revision is now accepted and ready to land.Nov 29 2018, 7:37 AM
habacker marked an inline comment as done.Nov 29 2018, 8:10 AM
habacker added inline comments.
kmymoney/plugins/views/reports/kreportsview.cpp
615

Comparing with the original 4.8 related changes https://cgit.kde.org/kmymoney.git/tree/kmymoney/views/kreportsview.cpp?h=4.8&id=bf6278f923ca1307a229c9ca1e8b206a4b82f400#n1100, this is okay. Configuring makes only sense if only one item is selected.

This revision was automatically updated to reflect the committed changes.
habacker marked an inline comment as done.
tbaumgart added inline comments.Nov 29 2018, 8:23 AM
kmymoney/plugins/views/reports/kreportsview.cpp
615

Sorry, I just meant to move the open paren onto the line with the if statement. This does not change the logic which indeed is exactly what we need: configuring just makes sense if only a single report is selected.