Differential D17224

Make the message TextField expanding, wrapping and scrollable
ClosedPublic
Actions

Authored by blaws on Nov 28 2018, 7:15 PM.

Details

Reviewers
sredman
Group Reviewers
KDE Connect
Commits
R224:c6fc4d92b721: Make the message TextField expanding, wrapping and scrollable
Summary

A scrollbar will show if the entered text fills more than 1/3rd
of the screen, pressing enter will send the message and shift +
enter will add a new line.

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
blaws created this revision.Nov 28 2018, 7:15 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 28 2018, 7:15 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
blaws requested review of this revision.Nov 28 2018, 7:15 PM
sredman accepted this revision.Nov 28 2018, 9:34 PM
sredman added a subscriber: sredman.

This looks great! Thanks very much! Just fix the one small issue blocking message sending before merging, please :)

smsapp/qml/ConversationDisplay.qml
43

I am having trouble sending messages with this patch 😂

This revision is now accepted and ready to land.Nov 28 2018, 9:34 PM
blaws added inline comments.Nov 28 2018, 11:01 PM
smsapp/qml/ConversationDisplay.qml
43

Oh, hahaha, commented out as have no credit, thought I removed this :)

blaws updated this revision to Diff 46495.Nov 29 2018, 6:02 PM

Uncomment function to send message

Closed by commit R224:c6fc4d92b721: Make the message TextField expanding, wrapping and scrollable (authored by blaws). · Explain WhyNov 29 2018, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmsapp/qml/ConversationDisplay.qml (33 lines)

Diff 46496

View Options

smsapp/qml/ConversationDisplay.qml

Loading...