Differential D17194

Fix DjVu links pointing to pages with different dimensions
ClosedPublic
Actions

Authored by akandaurov on Nov 27 2018, 5:59 PM.

Details

Reviewers
aacid
Group Reviewers
Okular
Commits
R223:b04a2daa6bd8: Fix DjVu links pointing to pages with different dimensions
Summary

Currently the coordinates of a link rectangle in a DjVu document are computed with respect to the size of the page the link is pointing to. Because of that, links only appear in correct places if the dimensions of a target page are the same as of the page containing the link.

The attached file demonstrating the issue contains two pages, one in portrait orientation and one in landscape, the first pointing to the second. The active zone for the link is different from where it is in other viewers.

misplaced-link.djvu1 KBDownload

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
akandaurov created this revision.Nov 27 2018, 5:59 PM
Restricted Application added a project: Okular. · View Herald TranscriptNov 27 2018, 5:59 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
akandaurov requested review of this revision.Nov 27 2018, 5:59 PM
akandaurov added a reviewer: Okular.
aacid accepted this revision.Nov 28 2018, 10:11 PM
aacid added a subscriber: aacid.

Looks good thanks :)

This revision is now accepted and ready to land.Nov 28 2018, 10:11 PM
Closed by commit R223:b04a2daa6bd8: Fix DjVu links pointing to pages with different dimensions (authored by akandaurov, committed by aacid). · Explain WhyNov 28 2018, 10:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mgenerators/djvu/generator_djvu.cpp (8 lines)

Diff 46434

View Options

generators/djvu/generator_djvu.cpp

Loading...