I've added Windows support to the systemvolume plugin.
Details
Details
- Reviewers
kdeconnect albertvaka - Group Reviewers
KDE Connect - Maniphest Tasks
- T10000: Media player control on Windows
- Commits
- R224:929fd062f2b6: Added Windows support to systemvolume plugin
Move the volume sliders in the Android app
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I tested this for a little bit and it seems to work pretty well. I think this is ready to be merged.
Comment Actions
I have a couple minor comments, but looks good to me. It would be nice to implement a really simple MPRIS plugin for Windows now (even if only sending multimedia key inputs), so this can be used form the Android app :P
| plugins/systemvolume/systemvolumeplugin-win.cpp | ||
|---|---|---|
| 261–270 | Can we merge these two into a single packet? Checking the Android side, you will also need to change an "else if" to become an "if", but I think it's cleaner. | |
| plugins/systemvolume/systemvolumeplugin-win.h | ||
| 29 | If these two are private classes, I prefer having them defined in the .ccp file instead of nested here. | |
Comment Actions
Can you do the Android side? Since you have commit access you can just commit directly. I'm too lazy to clone the repo and create a diff for a one word change.
Comment Actions
Done Android change here: https://commits.kde.org/kdeconnect-android/df0d02cd0d1f66e738d4072135a0baf657e86c19